Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[venstarthermostat] Update README.md #11730

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Conversation

raveydavies
Copy link
Contributor

Changed FanState channel to Switch and corrected small typing error

[venstarthermostat] README.md update to change fanState to Switch

This corrects documentation following recent binding update in which fanState was added as a Switch but incorrectly documented as a String.

Changed FanState channel to Switch and corrected small typing error

Signed-off-by: raveydavies <matthew.davies@skynet.be>
@raveydavies
Copy link
Contributor Author

@lolodomo I deleted the old PR because I was having a nightmare signing it off. It worked this time, although I did get the same DCO error again and needed to correct it. Not sure what is going on.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 8a8384e into openhab:main Dec 7, 2021
@lolodomo lolodomo added this to the 3.2 milestone Dec 7, 2021
@lolodomo lolodomo changed the title Update README.md [venstarthermostat] Update README.md Dec 10, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
Changed FanState channel to Switch and corrected small typing error

Signed-off-by: raveydavies <matthew.davies@skynet.be>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
Changed FanState channel to Switch and corrected small typing error

Signed-off-by: raveydavies <matthew.davies@skynet.be>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
Changed FanState channel to Switch and corrected small typing error

Signed-off-by: raveydavies <matthew.davies@skynet.be>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Changed FanState channel to Switch and corrected small typing error

Signed-off-by: raveydavies <matthew.davies@skynet.be>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Changed FanState channel to Switch and corrected small typing error

Signed-off-by: raveydavies <matthew.davies@skynet.be>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Changed FanState channel to Switch and corrected small typing error

Signed-off-by: raveydavies <matthew.davies@skynet.be>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants