[homekit] Add setting to block homekit user/pairing deletion

[yfre]

there are many reports about lost HomeKit user / pairing information from homekit.json

this PR add setting to block deletion of the user information by binding. the default setting is false which ensures the same behaviour as before this PR.

Signed-off-by: Eugen Freiter freiter@gmx.de

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-homekit-bug-fails-after-network-down-up/127101/14

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/homekit-bridge-to-oh3-lost/123130/31

[lolodomo]

Just two minor typo in doc

[lolodomo]

LGTM

[obartelt]

Great news! But how can I install this? I managed to find the JAR file (at https://ci.openhab.org/job/openHAB-Addons/lastSuccessfulBuild/artifact/bundles/org.openhab.io.homekit/target/) and copied it into the addons directory, and the bundle does get installed, but I cannot start it. Here's what it says:

265 │ Installed │  80 │ 3.2.0.202112130409    │ openHAB Add-ons :: Bundles :: IO :: Homekit                                                                                                                 
openhab> bundle:start 265                                                                                                                                                                                   
Error executing command: Error executing command on bundles:                                                                                                                                                
        Error starting bundle 265: Could not resolve module: org.openhab.io.homekit [265]                                                                                                                   
  Unresolved requirement: Import-Package: io.netty.bootstrap; version="[4.1.0,5.0.0)"

I read about bundle:resolve and tried "bundle:resolve 265", but that didn't output anything and the result is the same. Then I tried "bundle:requirements 265", because that seemed like a possible solution, but that just says "Bundle 265 is not resolved." :-(

I'm on openHAB 3.1.1. Thanks and sorry for messing up this thread, but I don't know where else to ask this!

[yfre]

@obartelt try with
install https://ci.openhab.org/job/openHAB-Addons/lastSuccessfulBuild/artifact/bundles/org.openhab.io.homekit/target/org.openhab.io.homekit-3.2.0-SNAPSHOT.jar

if it does not work, then install the stable version of binding via ui and then update with with
update <binding_id> https://ci.openhab.org/job/openHAB-Addons/lastSuccessfulBuild/artifact/bundles/org.openhab.io.homekit/target/org.openhab.io.homekit-3.2.0-SNAPSHOT.jar

[obartelt]

With install, it's the same message (I had tried that before, because I thought that it would resolve dependencies when doing it this way, but that doesn't seem to make any difference).

Ah, after installing the 3.1.1 version from the UI, it now has installed the dependencies as well. Strange, as I thought the io.netty packages are so basic that openHAB would need them by itself.

267 │ Active │  80 │ 4.1.63.Final          │ Netty/Buffer                                                                                                                                                   
268 │ Active │  80 │ 4.1.63.Final          │ Netty/Codec                                                                                                                                                    
269 │ Active │  80 │ 4.1.63.Final          │ Netty/Codec/HTTP                                                                                                                                               
270 │ Active │  80 │ 4.1.63.Final          │ Netty/Common                                                                                                                                                   
271 │ Active │  80 │ 4.1.63.Final          │ Netty/Handler                                                                                                                                                  
272 │ Active │  80 │ 4.1.63.Final          │ Netty/Resolver                                                                                                                                                 
273 │ Active │  80 │ 4.1.63.Final          │ Netty/Transport                                                                                                                                                
274 │ Active │  80 │ 3.1.1                 │ openHAB Add-ons :: Bundles :: IO :: Homekit

The update command did the trick. Thank you! I'm just curious as to why the dependencies aren't automatically installed when doing it via console or addons folder?

[obartelt]

Ok, while the update has worked now, I just witnessed something strange concerning the original problem (losing the pairing to the Home app in iOS):

When I restarted my docker container in which openHAB is running, the openHAB bridge completely disappeared from the Home app (I had the devices of the bridge open for debugging purposes, which went completely blank (just a white page with the bridge name on top). Then I went back to the bridge details, which were apparently still there, and then back to the home settings, where the bridge was missing all of a sudden).

Is there maybe a unpairing of sorts happening after all, when openHAB is stopped/restarted? The pairing did reappear and worked after openHAB was running again, but all my other bridges (virtual or real) stay visible inside the Home app when they're not running/connected, and just say that they're not available at the moment.

Maybe this helps. But as I said, the connection still worked after openHAB was up and running again and I even had forgotten to enable the setting of this pull request ;-)

[obartelt]

So far no issues with openHAB 3.2 Release. Great job, guys (and girls)!