[nikohomecontrol] Fix dimmer control sequence #11737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
lolodomo
requested changes
Dec 9, 2021
...rg/openhab/binding/nikohomecontrol/internal/protocol/nhc2/NikoHomeControlCommunication2.java
Outdated
Show resolved
Hide resolved
...rg/openhab/binding/nikohomecontrol/internal/protocol/nhc2/NikoHomeControlCommunication2.java
Outdated
Show resolved
Hide resolved
| @@ -627,6 +631,9 @@ public void executeAction(String actionId, String value) { | |||
| } else if (NHCOFF.equals(value)) { | |||
| property.status = value; | |||
| } else { | |||
| action.setState(Integer.parseInt(value)); // set cached state to new brightness value to avoid | |||
There was a problem hiding this comment.
No need to catch exception?
There was a problem hiding this comment.
It would be a bug if the value is not an int here, but I will put in a catch and log it (and do it at a few more places in the same class when I am at it).
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
|
@lolodomo Thanks for your review. Comments should have been addressed. |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Fix dimmer control sequence Signed-off-by: Mark Herwege <mark.herwege@telenet.be> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
* Fix dimmer control sequence Signed-off-by: Mark Herwege <mark.herwege@telenet.be> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Fix dimmer control sequence Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Fix dimmer control sequence Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Fix dimmer control sequence Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Fix dimmer control sequence Signed-off-by: Mark Herwege <mark.herwege@telenet.be> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Herwege mark.herwege@telenet.be
Closes #11695
The sequence of on/off and brightness commands and status updates caused flickering with lamps on other binding channels following the binding channels. This fix adjusts the sequence to avoid setting the wrong brightness value for a short instance before setting the correct value.