Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tplinksmarthome] Added new devices ES20, KP125, KP405 and KS230 #11771

Merged
merged 1 commit into from
Dec 20, 2021
Merged

[tplinksmarthome] Added new devices ES20, KP125, KP405 and KS230 #11771

merged 1 commit into from
Dec 20, 2021

Conversation

Hilbrand
Copy link
Member

No description provided.

@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Dec 13, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tp-link-outdoor-dimmer-plug-kp405-support/130120/2

lolodomo
lolodomo requested changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run the maven command to update the default i18n properties file.

mvn i18n:generate-default-translations

@Hilbrand
[tplinksmarthome] Added new devices ES20, KP125, KP405 and KS230
a864bda 
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
@Hilbrand Hilbrand requested a review from lolodomo December 19, 2021 16:22
lolodomo
lolodomo approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

I will merge after final 3.2 is released.

@lolodomo lolodomo merged commit 3a913a6 into openhab:main Dec 20, 2021
@lolodomo lolodomo added this to the 3.3 milestone Dec 20, 2021
@Hilbrand Hilbrand deleted the kp125 branch December 20, 2021 18:30
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tplinksmarthome-beta/130407/1

mherwege pushed a commit to mherwege/openhab-addons that referenced this pull request Dec 23, 2021
@Hilbrand @mherwege
[tplinksmarthome] Added new devices ES20, KP125, KP405 and KS230 (ope…
2ca7eef 
…nhab#11771)

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
@Hilbrand @NickWaterton
[tplinksmarthome] Added new devices ES20, KP125, KP405 and KS230 (ope…
431f753 
…nhab#11771)

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
@Hilbrand @mischmidt83
[tplinksmarthome] Added new devices ES20, KP125, KP405 and KS230 (ope…
89db79c 
…nhab#11771)

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@Hilbrand
[tplinksmarthome] Added new devices ES20, KP125, KP405 and KS230 (ope…
fffcaa2 
…nhab#11771)

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@Hilbrand @andan67
[tplinksmarthome] Added new devices ES20, KP125, KP405 and KS230 (ope…
694d5f7 
…nhab#11771)

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@Hilbrand @andrasU
[tplinksmarthome] Added new devices ES20, KP125, KP405 and KS230 (ope…
405fa34 
…nhab#11771)

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
joshproehl added a commit to joshproehl/openhab-addons that referenced this pull request Sep 6, 2024
@joshproehl
[tplinksmarthome] Add new device: EP25
38f4e68 
The EP25 appears to be a version of the KP125 that lacks the LED.
Because of this, and per the comments in openhab#16027, this commit
mimics openhab#11771 and simply copies the KP125, without the LED channel.
joshproehl added a commit to joshproehl/openhab-addons that referenced this pull request Sep 6, 2024
@joshproehl
[tplinksmarthome] Add new device: EP25
c17dc8a 
The EP25 appears to be a version of the KP125 that lacks the LED.
Because of this, and per the comments in openhab#16027, this commit
mimics openhab#11771 and simply copies the KP125, without the LED channel.
joshproehl added a commit to joshproehl/openhab-addons that referenced this pull request Sep 6, 2024
@joshproehl
[tplinksmarthome] Add new device: EP25
72165c0 
The EP25 appears to be a version of the KP125 that lacks the LED.
Because of this, and per the comments in openhab#16027, this commit
mimics openhab#11771 and simply copies the KP125, without the LED channel.

Signed-off-by: Josh Proehl <josh@daedalusdreams.com>
joshproehl added a commit to joshproehl/openhab-addons that referenced this pull request Sep 6, 2024
@joshproehl
[tplinksmarthome] Add new device: EP25
69aefef 
The EP25 appears to be a version of the KP125 that lacks the LED.
Because of this, and per the comments in openhab#16027, this commit
mimics openhab#11771 and simply copies the KP125, without the LED channel.

Signed-off-by: Josh Proehl <josh@daedalusdreams.com>
lsiepel pushed a commit that referenced this pull request Sep 6, 2024
@joshproehl
[tplinksmarthome] Add new device: EP25 (#17377)
bb28e6a 
The EP25 appears to be a version of the KP125 that lacks the LED.
Because of this, and per the comments in #16027, this commit
mimics #11771 and simply copies the KP125, without the LED channel.

Signed-off-by: Josh Proehl <josh@daedalusdreams.com>
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Sep 24, 2024
@joshproehl @digitaldan
[tplinksmarthome] Add new device: EP25 (openhab#17377)
b5ae095 
The EP25 appears to be a version of the KP125 that lacks the LED.
Because of this, and per the comments in openhab#16027, this commit
mimics openhab#11771 and simply copies the KP125, without the LED channel.

Signed-off-by: Josh Proehl <josh@daedalusdreams.com>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@joshproehl @pgfeller
[tplinksmarthome] Add new device: EP25 (openhab#17377)
b01d547 
The EP25 appears to be a version of the KP125 that lacks the LED.
Because of this, and per the comments in openhab#16027, this commit
mimics openhab#11771 and simply copies the KP125, without the LED channel.

Signed-off-by: Josh Proehl <josh@daedalusdreams.com>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@joshproehl @joni1993
[tplinksmarthome] Add new device: EP25 (openhab#17377)
eb83045 
The EP25 appears to be a version of the KP125 that lacks the LED.
Because of this, and per the comments in openhab#16027, this commit
mimics openhab#11771 and simply copies the KP125, without the LED channel.

Signed-off-by: Josh Proehl <josh@daedalusdreams.com>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@joshproehl @matchews
[tplinksmarthome] Add new device: EP25 (openhab#17377)
d0b2ba8 
The EP25 appears to be a version of the KP125 that lacks the LED.
Because of this, and per the comments in openhab#16027, this commit
mimics openhab#11771 and simply copies the KP125, without the LED channel.

Signed-off-by: Josh Proehl <josh@daedalusdreams.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@Hilbrand @openhab-bot @lolodomo