Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icalendar] Added original texts for translation #11928

Merged

Conversation

daMihe
Copy link
Contributor

@daMihe daMihe commented Jan 2, 2022

Just added originals so they can be edited via crowdin.

Signed-off-by: Michael Wodniok <michi@noorganization.org>
@cweitkamp
Copy link
Contributor

Thank you for taking care. Would be nice if you can add a pattern for channel types which can be linked to a DateTime item type - like I did in #11618 for the feed binding. This way we can provide localized formats for date/time values too.

And do not forget to run mvn i18n:generate-default-translations afterwards.

@cweitkamp cweitkamp added enhancement An enhancement or new feature for an existing add-on translation labels Jan 2, 2022
Signed-off-by: Michael Wodniok <michi@noorganization.org>
@daMihe daMihe requested a review from cweitkamp January 2, 2022 10:43
@daMihe daMihe linked an issue Jan 2, 2022 that may be closed by this pull request
@daMihe
Copy link
Contributor Author

daMihe commented Jan 2, 2022

Thank you for the hint. Built the addon and also rebuilt translation source.

@@ -171,7 +172,8 @@
<option value="WEEK">week</option>
</options>
<default>HOUR</default>
<label>Date or Time Unit for Start and End</label>
<label>Date/Time Unit</label>
<description>Date or Time Unit for Start and End</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For description, use uppercase only for the first letter of the first word, not for all words.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Is there an english language based reason when to use capitalization or are labels nouns just capitalized by convention?

Signed-off-by: Michael Wodniok <michi@noorganization.org>
@daMihe daMihe requested a review from lolodomo January 2, 2022 19:57
@cweitkamp cweitkamp merged commit 4a8fd56 into openhab:main Jan 3, 2022
@wborn wborn changed the title [icalendar] fixes #11927: Added original texts for translation [icalendar] Added original texts for translation Jan 3, 2022
@wborn wborn added this to the 3.3 milestone Jan 4, 2022
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…openhab#11928)

* [icalendar] fixes openhab#11927: Added original texts for translation

Signed-off-by: Michael Wodniok <michi@noorganization.org>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
…openhab#11928)

* [icalendar] fixes openhab#11927: Added original texts for translation

Signed-off-by: Michael Wodniok <michi@noorganization.org>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
…openhab#11928)

* [icalendar] fixes openhab#11927: Added original texts for translation

Signed-off-by: Michael Wodniok <michi@noorganization.org>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
…openhab#11928)

* [icalendar] fixes openhab#11927: Added original texts for translation

Signed-off-by: Michael Wodniok <michi@noorganization.org>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…openhab#11928)

* [icalendar] fixes openhab#11927: Added original texts for translation

Signed-off-by: Michael Wodniok <michi@noorganization.org>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…openhab#11928)

* [icalendar] fixes openhab#11927: Added original texts for translation

Signed-off-by: Michael Wodniok <michi@noorganization.org>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[icalendar] Not all translations are in original language available
4 participants