Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amazonechocontrol] Fix refresh time for skill connected devices #11943

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Jan 2, 2022

It was recently discovered that during the refactoring from #6140 to #7969 I made a mistake that could lead to very frequent requests and high load on smarthome skills (ioBroker and openHAB). Since at least AWS hosted skills are paid per request this has the potential to cause high bills for the skill authors. I'm very sorry for that.

@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label Jan 2, 2022
@J-N-K J-N-K requested a review from mgeramb as a code owner January 2, 2022 22:50
Signed-Off-By: Jan N. Klug <github@klug.nrw>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@wborn wborn merged commit aaf0132 into openhab:main Jan 3, 2022
@wborn wborn added this to the 3.3 milestone Jan 3, 2022
@wborn wborn changed the title [amazonechocontrol] fix refresh time for skill connected devices [amazonechocontrol] Fix refresh time for skill connected devices Jan 3, 2022
@J-N-K J-N-K deleted the fix-aec branch January 3, 2022 15:00
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…nhab#11943)

Signed-Off-By: Jan N. Klug <github@klug.nrw>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
…nhab#11943)

Signed-Off-By: Jan N. Klug <github@klug.nrw>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…nhab#11943)

Signed-Off-By: Jan N. Klug <github@klug.nrw>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants