Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nikohomecontrol] Bug fixes and improvements to thermostats #11963

Merged
merged 4 commits into from
Jun 15, 2022
Merged

[nikohomecontrol] Bug fixes and improvements to thermostats #11963

merged 4 commits into from
Jun 15, 2022

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Jan 4, 2022 •
edited
Loading

Depends on PR #12885

The focus of this PR is now solely on improving thermostats:

  • Thermostats now also have string channels. These make it easier to map the inputs and outputs without rules (as all assistants use string channels). The old (numeric) channels have been declared advanced.
  • A few bugs with thermostats have been fixed.

@mherwege mherwege added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Jan 4, 2022
@mherwege mherwege force-pushed the thermostats branch 2 times, most recently from eb6ce04 to 7dc2aac Compare January 13, 2022 08:22
@lolodomo lolodomo removed the bug An unexpected problem or unintended behavior of an add-on label Jan 14, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/niko-home-control-v1-thermostat-not-working/132894/2

@mherwege mherwege mentioned this pull request Feb 9, 2022
Closed
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/niko-home-control-ii/44586/410

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/niko-home-control-extended-version-beta/135378/1

This was referenced May 26, 2022
Merged
Merged
@mherwege
Copy link
Contributor Author

mherwege commented Jun 1, 2022

Trying to reduce the scope of the review effort, I am isolating changes in this PR into separate PR's. Once these are reviewed and merged, I will rebase what is left for this PR and request a review.

@mherwege mherwege added work in progress A PR that is not yet ready to be merged awaiting other PR Depends on another PR labels Jun 1, 2022
This was referenced Jun 2, 2022
Merged
Merged
@mherwege
Copy link
Contributor Author

mherwege commented Jun 5, 2022

The focus of this PR has been reduced to thermostat improvements only. It does still build on top of PR #12885. When that PR has been reviewed and merged, this PR will be rebased for review.

@mherwege mherwege mentioned this pull request Jun 5, 2022
Merged
@mherwege mherwege removed the work in progress A PR that is not yet ready to be merged label Jun 5, 2022
@mherwege mherwege changed the title [nikohomecontrol] Bug fixes and improvements to thermostats and connection logic [nikohomecontrol] Bug fixes and improvements to thermostats Jun 6, 2022
@lolodomo
Copy link
Contributor

lolodomo commented Jun 12, 2022 •
edited
Loading

We can try to include this one in final v3.3 if you can rebase soon ;) This should not be too many lines to review after the rebase ;)

@mherwege
Thermostat fixes and implement extra thermostat channels
1fca64f 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege removed the awaiting other PR Depends on another PR label Jun 12, 2022
@mherwege
Copy link
Contributor Author

@lolodomo I just rebased it. Let me know what you think.

lolodomo
lolodomo requested changes Jun 13, 2022
View reviewed changes
bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.nikohomecontrol/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.nikohomecontrol/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.nikohomecontrol/README.md Show resolved Hide resolved
bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
...rc/main/java/org/openhab/binding/nikohomecontrol/internal/NikoHomeControlHandlerFactory.java Outdated Show resolved Hide resolved
...java/org/openhab/binding/nikohomecontrol/internal/handler/NikoHomeControlBridgeHandler1.java Outdated Show resolved Hide resolved
...a/org/openhab/binding/nikohomecontrol/internal/handler/NikoHomeControlThermostatHandler.java Outdated Show resolved Hide resolved
@mherwege
Review comments
843b56c 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Copy link
Contributor Author

@lolodomo Thank you for your feedback. I have addressed most of your comments, and left a few comments.

mherwege and others added 2 commits June 14, 2022 00:04
@mherwege
Fix handler factory activation
35d15f1 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@lolodomo @mherwege
Enhance handling of setpoint command
ffcdec5 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@mherwege
Copy link
Contributor Author

mherwege commented Jun 15, 2022 •
edited
Loading

@lolodomo Thanks for helping out on this. I was busy yesterday, did not have time to look into it. Your proposal looks good. This warning was something that was bothering me for quite a while already.

lolodomo
lolodomo approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit f8bbb2b into openhab:main Jun 15, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jun 15, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@mherwege @leifbladt
[nikohomecontrol] Bug fixes and improvements to thermostats (openhab#…
92c8991 
…11963)

* Thermostat fixes and implement extra thermostat channels

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@mherwege @andan67
[nikohomecontrol] Bug fixes and improvements to thermostats (openhab#…
cf7b854 
…11963)

* Thermostat fixes and implement extra thermostat channels

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@mherwege @andrasU
[nikohomecontrol] Bug fixes and improvements to thermostats (openhab#…
2dcd25a 
…11963)

* Thermostat fixes and implement extra thermostat channels

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@mherwege @psmedley
[nikohomecontrol] Bug fixes and improvements to thermostats (openhab#…
1086cfb 
…11963)

* Thermostat fixes and implement extra thermostat channels

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@mherwege @nemerdaud
[nikohomecontrol] Bug fixes and improvements to thermostats (openhab#…
0bb4278 
…11963)

* Thermostat fixes and implement extra thermostat channels

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege deleted the thermostats branch March 7, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mherwege @openhab-bot @lolodomo