[awattar] Initial contribution #11976

Wolfgang1966 · 2022-01-06T16:14:27Z

Around one year ago I started developing a binding to retrieve energy prices for the German/Austrian electricity provider aWATTar. Find the discussion at
https://community.openhab.org/t/awattar-binding-beta-and-discussion/110497

The goal of the binding is to enable aWATTar customers to make use of hours with lower energy prices for equipment that consumes a lot of energy but does not need to run all the time, e.g. wallboxes.

A few people are using the binding already in their openHAB installation. They found a few bugs which were already corrected since then.

Before opening this PR I rebased my branch to the current main branch to avoid merge conflicts.

The latest version of the binding is available for download at
https://home.klimt.de/owncloud/index.php/s/zKAsTWkxjG6RLyS

I did my best to follow the requirements for new bindings. However, as this is my first one, I may have overlooked things, If I did, I appreciate any comments.

openhab-bot · 2022-01-06T16:15:47Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/awattar-binding-beta-and-discussion/110497/39

lolodomo · 2022-01-15T11:11:06Z

@Wolfgang1966 : I mark this PR with label "work in progress" in relation to your PR tile. Let us know when your work is finished and ready for a review.

Wolfgang1966 · 2022-01-15T11:18:58Z

Hi @lolodomo , thanks for bringing this up. I removed the "WIP" from the title, as I now managed to get rid of all warnings (at least when building the code locally). So I would appreciate a first review to get some feedback. As I wrote, this is the first binding I wrote from scratch and there may be fundamental things I failed to implement the way it should be. I assume the first review brings up those things and will require deeper rework which will take some time. Afterwards, there may be smaller detail work necessary, but I think this only makes sense as soon as the overall structure is finalized and stable.

fwolter

Thanks for your contribution! I reviewed your code and here is my feedback.

You could use mvn license:format in the root directory of this repo to update the copyright year.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.

Please add your binding to bom\openhab-addons\pom.xml.

bundles/org.openhab.binding.awattar/README.md

bundles/org.openhab.binding.awattar/src/main/feature/feature.xml

...openhab.binding.awattar/src/main/java/org/openhab/binding/awattar/internal/aWATTarPrice.java

....openhab.binding.awattar/src/main/java/org/openhab/binding/awattar/internal/aWATTarUtil.java

bundles/org.openhab.binding.awattar/src/main/resources/OH-INF/binding/binding.xml

fwolter · 2022-02-27T18:21:06Z

bundles/org.openhab.binding.awattar/src/main/resources/OH-INF/i18n/awattar_de.properties

@@ -0,0 +1,166 @@
+binding.awattar.name = aWATTar Binding


@lolodomo Shall this be part of the binding?

No, it is better to translate in Crowdin.
But if the translation was fully done that way, as it is a new binding, an exception could be done : just after the merge, someone should take care to load the German transitions in Crowdin.

I removed the name from the properties file

It was about the entire file. As you already did all translations in the properties file, I suggest you to add the name property again and after this has been merged, you ask a maintainer to load your whole translation into Crowdin.

@lolodomo @jlaur can you load the German translations into Crowdin?

bundles/org.openhab.binding.awattar/src/main/resources/OH-INF/thing/thing-types.xml

Wolfgang1966 · 2022-04-16T16:28:25Z

@fwolter @lolodomo Finally found some time to work on your comments. Hope to be able to push an update within the next days. Sorry for the delay.

Wolfgang1966 · 2022-04-17T15:57:32Z

Hi @fwolter and @lolodomo , I now did the requested changes and also the checkstyle report, with the following exception:

At two places I need the ScheduleAtFixedRate because the actions need to happen at minute boundaries. Otherwise I would have to schedule much more often than once per minute, which would most probably cause much more load than the more efficient scheduler might save.

Is there any way to avoid the warning in such cases?

Wolfgang1966 · 2022-04-17T16:06:37Z

I just saw that the build fails because of the year in the header line. However, this is the line I got with

mvn license:format

and with "2022" the checkstyle report gives errors. Do I need to rebase the whole PR to a newer openHAB version to get rid of this problem?

fwolter

To make the binding compile, you need to rebase your branch and set the version to the current snapshot: 3.3.0-SNAPSHOT.

Here are the commands for rebasing your branch:

If not already done, add the upstream openHAB addon repo as a remote to your local repo and fetch it:

git remote add upstream https://github.com/openhab/openhab-addons.git
git fetch upstream

The remotes (git remote --verbose) should look like this, now:

origin  https://github.com/[your name]/openhab-addons.git (fetch)
origin  https://github.com/[your name]/openhab-addons.git (push)
upstream        https://github.com/openhab/openhab-addons.git (fetch)
upstream        https://github.com/openhab/openhab-addons.git (push)

Then, you can rebase your PR's branch onto main:

git rebase upstream/main

Finally force-push the rebased branch to this PR's branch:

git push origin [your branch name of this PR] --force-with-lease

DON'T use merge! This can clutter the Git history and make the PR unusable.

Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de>

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Obeyed most of the review comments. Exceptions: * binding is already added to bom/openhab-addons/pom.xml (at least I found it there and there was a commit notice in git log) * mvn license:format brought back 2021, so I manually set everything to 2022. Should I try to rebase my whole branch? * In two places the binding needs to adjust to minute boundaries, hence scheduleWithFixedDelay will not work. * I removed empty trailing lines, but mvn spotless:apply brought them back * The OhInfXmlUsageCheck seems to be wrong. * The ConstantNameCheck in AwattarUtil seems to be mislead by the fact that all members of the class are static, including the logger. From my point of view it is not a real "constant". Signed-off-by: Wolfgang Klimt <github@klimt.de>

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Wolfgang1966 · 2022-04-24T15:03:51Z

Branch rebased.

...wattar/src/main/java/org/openhab/binding/awattar/internal/handler/AwattarHandlerFactory.java

bundles/org.openhab.binding.awattar/src/main/resources/OH-INF/binding/binding.xml

bundles/org.openhab.binding.awattar/src/main/resources/OH-INF/thing/thing-types.xml

fwolter · 2022-04-30T09:23:46Z

bundles/org.openhab.binding.awattar/src/main/resources/OH-INF/i18n/awattar_de.properties

@@ -0,0 +1,166 @@
+binding.awattar.name = aWATTar Binding


It was about the entire file. As you already did all translations in the properties file, I suggest you to add the name property again and after this has been merged, you ask a maintainer to load your whole translation into Crowdin.

fwolter · 2022-04-30T09:28:01Z

...ttar/src/main/java/org/openhab/binding/awattar/internal/handler/AwattarBestpriceHandler.java

+                thingRefresher = scheduler.scheduleAtFixedRate(this::refreshChannels,
+                        getMillisToNextMinute(1, timeZoneProvider), thingRefreshInterval * 1000, TimeUnit.MILLISECONDS);
+            }
+


This empty line needs to be removed to satisfy checkstyle.

Removed it, however, There was no warning when I built the binding locally. I will double check the build result after push.

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Wolfgang1966 · 2022-05-01T13:14:44Z

Added the name property again, will take care of Crowdin after merge.

fwolter

LGTM
Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

Wolfgang1966 · 2022-05-02T05:03:57Z

Hi @fwolter , thanks for your approval.

Yours

Wolfgang

Wolfgang1966 · 2022-05-02T06:59:32Z

Contacted aWATTar for the Logo

lolodomo · 2022-05-02T15:19:14Z

For your information, I uploaded the German translations in Crowdin.

I noticed these warnings when I compile:

[INFO] --- sat-plugin:0.12.0:report (sat-all) @ org.openhab.binding.awattar ---
[INFO] Individual report appended to summary report.
[WARNING] Code Analysis Tool has found:
 0 error(s)!
 2 warning(s)
 0 info(s)
[WARNING] org.openhab.binding.awattar.internal.handler.AwattarBestpriceHandler.java:[106]
For periodically executed jobs that do not require a fixed rate scheduleWithFixedDelay should be preferred over scheduleAtFixedRate.
[WARNING] org.openhab.binding.awattar.internal.handler.AwattarPriceHandler.java:[93]
For periodically executed jobs that do not require a fixed rate scheduleWithFixedDelay should be preferred over scheduleAtFixedRate.

fwolter · 2022-05-02T15:35:57Z

Thanks! This is one of the rare cases where scheduleAtFixedRate needs to be used.

lolodomo · 2022-05-02T15:44:37Z

Ok

Wolfgang1966 · 2022-05-03T05:16:50Z

Is it possible to suppress the warning by some annotation or preceding comment in the code?

fwolter · 2022-05-03T06:04:56Z

Good idea! You could annotate the method using it with @SuppressWarnings("PMD.AvoidScheduleAtFixedRateCheck").

@fwolter

* First alpha version of the awattar binding Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected typos Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * More typos Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Improved time handling to consider time zone. Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected logical time problem, start adding nextprice thing Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Added support for Austria Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Use List instead of Set Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Minor corrections Signed-off-by: Wolfgang Klimt <github@klimt.de> * Removed unneeded handler, corrected fetching of prices Signed-off-by: Wolfgang Klimt <github@klimt.de> * Added i18n, updated documentation Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected pom.xml after rebase Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updated version to 3.3.0-SNAPSHOT Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected findings of Code analysis tool Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updated copyright notice Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updates to get rid of compiler warnings Signed-off-by: Wolfgang Klimt <github@klimt.de> * Worked on review comments from @fwolter Obeyed most of the review comments. Exceptions: * binding is already added to bom/openhab-addons/pom.xml (at least I found it there and there was a commit notice in git log) * mvn license:format brought back 2021, so I manually set everything to 2022. Should I try to rebase my whole branch? * In two places the binding needs to adjust to minute boundaries, hence scheduleWithFixedDelay will not work. * I removed empty trailing lines, but mvn spotless:apply brought them back * The OhInfXmlUsageCheck seems to be wrong. * The ConstantNameCheck in AwattarUtil seems to be mislead by the fact that all members of the class are static, including the logger. From my point of view it is not a real "constant". Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updated Readme to match code changes Signed-off-by: Wolfgang Klimt <github@klimt.de> * Further work on review comments from @fwolter Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected config definition Signed-off-by: Wolfgang Klimt <github@klimt.de> * Changed Copyright to 2022 Signed-off-by: Wolfgang Klimt <github@klimt.de> * Review comments from @fwolter. Improved timezone handling Signed-off-by: Wolfgang Klimt <github@klimt.de> Co-authored-by: wolfii <wolfgang.klimt@consol.de>

@fwolter

* First alpha version of the awattar binding Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected typos Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * More typos Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Improved time handling to consider time zone. Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected logical time problem, start adding nextprice thing Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Added support for Austria Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Use List instead of Set Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Minor corrections Signed-off-by: Wolfgang Klimt <github@klimt.de> * Removed unneeded handler, corrected fetching of prices Signed-off-by: Wolfgang Klimt <github@klimt.de> * Added i18n, updated documentation Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected pom.xml after rebase Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updated version to 3.3.0-SNAPSHOT Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected findings of Code analysis tool Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updated copyright notice Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updates to get rid of compiler warnings Signed-off-by: Wolfgang Klimt <github@klimt.de> * Worked on review comments from @fwolter Obeyed most of the review comments. Exceptions: * binding is already added to bom/openhab-addons/pom.xml (at least I found it there and there was a commit notice in git log) * mvn license:format brought back 2021, so I manually set everything to 2022. Should I try to rebase my whole branch? * In two places the binding needs to adjust to minute boundaries, hence scheduleWithFixedDelay will not work. * I removed empty trailing lines, but mvn spotless:apply brought them back * The OhInfXmlUsageCheck seems to be wrong. * The ConstantNameCheck in AwattarUtil seems to be mislead by the fact that all members of the class are static, including the logger. From my point of view it is not a real "constant". Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updated Readme to match code changes Signed-off-by: Wolfgang Klimt <github@klimt.de> * Further work on review comments from @fwolter Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected config definition Signed-off-by: Wolfgang Klimt <github@klimt.de> * Changed Copyright to 2022 Signed-off-by: Wolfgang Klimt <github@klimt.de> * Review comments from @fwolter. Improved timezone handling Signed-off-by: Wolfgang Klimt <github@klimt.de> Co-authored-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

@fwolter

* First alpha version of the awattar binding Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected typos Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * More typos Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Improved time handling to consider time zone. Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected logical time problem, start adding nextprice thing Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Added support for Austria Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Use List instead of Set Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de> * Minor corrections Signed-off-by: Wolfgang Klimt <github@klimt.de> * Removed unneeded handler, corrected fetching of prices Signed-off-by: Wolfgang Klimt <github@klimt.de> * Added i18n, updated documentation Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected pom.xml after rebase Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updated version to 3.3.0-SNAPSHOT Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected findings of Code analysis tool Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updated copyright notice Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updates to get rid of compiler warnings Signed-off-by: Wolfgang Klimt <github@klimt.de> * Worked on review comments from @fwolter Obeyed most of the review comments. Exceptions: * binding is already added to bom/openhab-addons/pom.xml (at least I found it there and there was a commit notice in git log) * mvn license:format brought back 2021, so I manually set everything to 2022. Should I try to rebase my whole branch? * In two places the binding needs to adjust to minute boundaries, hence scheduleWithFixedDelay will not work. * I removed empty trailing lines, but mvn spotless:apply brought them back * The OhInfXmlUsageCheck seems to be wrong. * The ConstantNameCheck in AwattarUtil seems to be mislead by the fact that all members of the class are static, including the logger. From my point of view it is not a real "constant". Signed-off-by: Wolfgang Klimt <github@klimt.de> * Updated Readme to match code changes Signed-off-by: Wolfgang Klimt <github@klimt.de> * Further work on review comments from @fwolter Signed-off-by: Wolfgang Klimt <github@klimt.de> * Corrected config definition Signed-off-by: Wolfgang Klimt <github@klimt.de> * Changed Copyright to 2022 Signed-off-by: Wolfgang Klimt <github@klimt.de> * Review comments from @fwolter. Improved timezone handling Signed-off-by: Wolfgang Klimt <github@klimt.de> Co-authored-by: wolfii <wolfgang.klimt@consol.de>

Wolfgang1966 requested a review from a team as a code owner January 6, 2022 16:14

fwolter added the new binding If someone has started to work on a binding. For a new binding PR. label Jan 6, 2022

lolodomo added the work in progress A PR that is not yet ready to be merged label Jan 15, 2022

Wolfgang1966 changed the title ~~[awattar] WIP Initial contribution~~ [awattar] Initial contribution Jan 15, 2022

lolodomo removed the work in progress A PR that is not yet ready to be merged label Jan 15, 2022

fwolter requested changes Feb 27, 2022

View reviewed changes

lolodomo added the awaiting feedback Awaiting feedback from the pull request author label Apr 10, 2022

Wolfgang1966 requested a review from fwolter April 17, 2022 16:10

fwolter requested changes Apr 18, 2022

View reviewed changes

fwolter removed the awaiting feedback Awaiting feedback from the pull request author label Apr 18, 2022

wolfii and others added 14 commits April 24, 2022 16:43

First alpha version of the awattar binding

dc0d1f7

Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de>

Corrected typos

60894a4

Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de>

More typos

88bd73e

Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de>

Improved time handling to consider time zone.

359c00e

Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de>

Corrected logical time problem, start adding nextprice thing

a7f0934

Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de>

Added support for Austria

4ec30ad

Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de>

Use List instead of Set

0ad54c4

Signed-off-by: wolfii <wolfgang.klimt@consol.de> Signed-off-by: Wolfgang Klimt <github@klimt.de>

Minor corrections

b639a47

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Removed unneeded handler, corrected fetching of prices

6fc511c

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Added i18n, updated documentation

1c2c2bd

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Corrected pom.xml after rebase

c2c94bb

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Updated version to 3.3.0-SNAPSHOT

c02774a

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Corrected findings of Code analysis tool

0a2316e

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Updated copyright notice

9d17a7c

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Wolfgang Klimt added 6 commits April 24, 2022 16:46

Updates to get rid of compiler warnings

ee6a694

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Updated Readme to match code changes

f24f4b8

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Further work on review comments from @fwolter

0fe4771

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Corrected config definition

61b8b39

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Changed Copyright to 2022

a338a86

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Wolfgang1966 requested a review from fwolter April 24, 2022 15:04

fwolter reviewed Apr 30, 2022

View reviewed changes

Review comments from @fwolter. Improved timezone handling

aeda233

Signed-off-by: Wolfgang Klimt <github@klimt.de>

Wolfgang1966 requested a review from fwolter May 1, 2022 13:15

fwolter approved these changes May 1, 2022

View reviewed changes

fwolter merged commit 61de1a5 into openhab:main May 2, 2022

fwolter added this to the 3.3 milestone May 2, 2022

Wolfgang1966 deleted the awattar branch May 2, 2022 06:59

Confectrician mentioned this pull request May 2, 2022

New Logo for aWATTar Binding. openhab/openhab-docs#1807

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[awattar] Initial contribution #11976

[awattar] Initial contribution #11976

Wolfgang1966 commented Jan 6, 2022

openhab-bot commented Jan 6, 2022

lolodomo commented Jan 15, 2022

Wolfgang1966 commented Jan 15, 2022

fwolter left a comment

fwolter Feb 27, 2022

lolodomo Apr 5, 2022 •

edited

Loading

Wolfgang1966 Apr 17, 2022

fwolter Apr 30, 2022

fwolter May 2, 2022

Wolfgang1966 commented Apr 16, 2022

Wolfgang1966 commented Apr 17, 2022

Wolfgang1966 commented Apr 17, 2022

fwolter left a comment

Wolfgang1966 commented Apr 24, 2022

fwolter Apr 30, 2022

fwolter Apr 30, 2022

Wolfgang1966 May 1, 2022

Wolfgang1966 commented May 1, 2022

fwolter left a comment

Wolfgang1966 commented May 2, 2022 •

edited

Loading

Wolfgang1966 commented May 2, 2022

lolodomo commented May 2, 2022 •

edited

Loading

fwolter commented May 2, 2022

lolodomo commented May 2, 2022

Wolfgang1966 commented May 3, 2022

fwolter commented May 3, 2022 •

edited

Loading

[awattar] Initial contribution #11976

[awattar] Initial contribution #11976

Conversation

Wolfgang1966 commented Jan 6, 2022

openhab-bot commented Jan 6, 2022

lolodomo commented Jan 15, 2022

Wolfgang1966 commented Jan 15, 2022

fwolter left a comment

Choose a reason for hiding this comment

fwolter Feb 27, 2022

Choose a reason for hiding this comment

lolodomo Apr 5, 2022 • edited Loading

Choose a reason for hiding this comment

Wolfgang1966 Apr 17, 2022

Choose a reason for hiding this comment

fwolter Apr 30, 2022

Choose a reason for hiding this comment

fwolter May 2, 2022

Choose a reason for hiding this comment

Wolfgang1966 commented Apr 16, 2022

Wolfgang1966 commented Apr 17, 2022

Wolfgang1966 commented Apr 17, 2022

fwolter left a comment

Choose a reason for hiding this comment

Wolfgang1966 commented Apr 24, 2022

fwolter Apr 30, 2022

Choose a reason for hiding this comment

fwolter Apr 30, 2022

Choose a reason for hiding this comment

Wolfgang1966 May 1, 2022

Choose a reason for hiding this comment

Wolfgang1966 commented May 1, 2022

fwolter left a comment

Choose a reason for hiding this comment

Wolfgang1966 commented May 2, 2022 • edited Loading

Wolfgang1966 commented May 2, 2022

lolodomo commented May 2, 2022 • edited Loading

fwolter commented May 2, 2022

lolodomo commented May 2, 2022

Wolfgang1966 commented May 3, 2022

fwolter commented May 3, 2022 • edited Loading

lolodomo Apr 5, 2022 •

edited

Loading

Wolfgang1966 commented May 2, 2022 •

edited

Loading

lolodomo commented May 2, 2022 •

edited

Loading

fwolter commented May 3, 2022 •

edited

Loading