[nuki] Support for SmartLock 3.0 and SmartDoor #12005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/new-openhab2-binding-for-nuki-smart-locks/25940/177 |
lolodomo
requested changes
Jan 9, 2022
...i/src/main/java/org/openhab/binding/nuki/internal/configuration/NukiDeviceConfiguration.java
Outdated
Show resolved
Hide resolved
...ki/src/main/java/org/openhab/binding/nuki/internal/discovery/NukiDeviceDiscoveryService.java
Show resolved
Hide resolved
bundles/org.openhab.binding.nuki/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
bundles/org.openhab.binding.nuki/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
moesterheld
pushed a commit
to moesterheld/openhab-addons
that referenced
this pull request
Jan 18, 2022
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Jan Vybíral <jan.vybiral1@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for recently released products - Smart Lock 3.0 and Smart Door.
This is pretty simple PR since both new devices behave the same as Smart Lock 2.0, the only change needed is to allow devices with new deviceTypes (3, 4) to be recognized by discovery as smartlock.
Added new
deviceTyperead only property (since now there are 3 smartlock deviceTypes) on smartlock thing because all actions on bridge require deviceType to be sent with request. This is just to be sure, there does not seem to be any difference sending deviceType 0, 3 or 4 (my smartlock 2.0 works the same with any of these values), this property seems to only exist to distinguish smartlock and opener calls.I also updated documentation on
smartlockDoorStatechannel to include new values introduced in v 1.13.1 of the bridge API.