Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pushover] Improved exception handling #12023

Merged
merged 2 commits into from
Jan 16, 2022

Conversation

cweitkamp
Copy link
Contributor

  • Improved exception handling

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp added the enhancement An enhancement or new feature for an existing add-on label Jan 11, 2022
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is cool that you used these new exception classes.
I have few comments.

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp force-pushed the feature-pushover-exception-handling branch from 3718f69 to 33df91f Compare January 16, 2022 16:36
@cweitkamp
Copy link
Contributor Author

I incorporated all your comments.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 8b3bb31 into openhab:main Jan 16, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jan 16, 2022
@cweitkamp cweitkamp deleted the feature-pushover-exception-handling branch January 16, 2022 17:16
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
* Improved exception handling

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
* Improved exception handling

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
* Improved exception handling

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Improved exception handling

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* Improved exception handling

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants