-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pushover] Improved exception handling #12023
Merged
lolodomo
merged 2 commits into
openhab:main
from
cweitkamp:feature-pushover-exception-handling
Jan 16, 2022
Merged
[pushover] Improved exception handling #12023
lolodomo
merged 2 commits into
openhab:main
from
cweitkamp:feature-pushover-exception-handling
Jan 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Jan 11, 2022
lolodomo
requested changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is cool that you used these new exception classes.
I have few comments.
...er/src/main/java/org/openhab/binding/pushover/internal/connection/PushoverAPIConnection.java
Show resolved
Hide resolved
...er/src/main/java/org/openhab/binding/pushover/internal/connection/PushoverAPIConnection.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/openhab/binding/pushover/internal/connection/PushoverMessageBuilder.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/openhab/binding/pushover/internal/connection/PushoverMessageBuilder.java
Outdated
Show resolved
Hide resolved
...over/src/main/java/org/openhab/binding/pushover/internal/handler/PushoverAccountHandler.java
Outdated
Show resolved
Hide resolved
...over/src/main/java/org/openhab/binding/pushover/internal/handler/PushoverAccountHandler.java
Outdated
Show resolved
Hide resolved
...over/src/main/java/org/openhab/binding/pushover/internal/handler/PushoverAccountHandler.java
Outdated
Show resolved
Hide resolved
...over/src/main/java/org/openhab/binding/pushover/internal/handler/PushoverAccountHandler.java
Outdated
Show resolved
Hide resolved
...over/src/main/java/org/openhab/binding/pushover/internal/handler/PushoverAccountHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-pushover-exception-handling
branch
from
January 16, 2022 16:36
3718f69
to
33df91f
Compare
I incorporated all your comments. |
lolodomo
approved these changes
Jan 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
moesterheld
pushed a commit
to moesterheld/openhab-addons
that referenced
this pull request
Jan 18, 2022
* Improved exception handling Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Improved exception handling Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
* Improved exception handling Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Improved exception handling Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Improved exception handling Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de