Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[digitalstrom] Adoptions due to API changes in DSS Update 1.19.2 #12033

Merged
merged 6 commits into from
Jan 14, 2022
Merged

[digitalstrom] Adoptions due to API changes in DSS Update 1.19.2 #12033

merged 6 commits into from
Jan 14, 2022

Conversation

alexf2015
Copy link
Contributor

@alexf2015 alexf2015 commented Jan 12, 2022 •
edited
Loading

Fixes #11847
This should fix the issue introduced by DSS update to 1.19.2 while staying backwards compatible to older versions of DSS.

@alexf2015 alexf2015 changed the title [digitalstrom] Fix for #11847 Power Consumption and Energy Level NULL after DSS Update to 1.19.2 [digitalstrom] adoptions due to API changes in DSS Update 1.19.2 Jan 12, 2022
@lolodomo
Copy link
Contributor

Please apply spotless: mvn spotless:apply

@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Jan 13, 2022
@jlaur jlaur changed the title [digitalstrom] adoptions due to API changes in DSS Update 1.19.2 [digitalstrom] Adoptions due to API changes in DSS Update 1.19.2 Jan 13, 2022
@lolodomo
Copy link
Contributor

@MichaelOchel @msiegele for review

@hmerk
Copy link
Contributor

hmerk commented Jan 13, 2022 •
edited
Loading

@lolodomo We need to remove MichaelOechel and msiegele from codeowners, as they have finished their student project and will no onger maintain the binding.

@lolodomo
Copy link
Contributor

lolodomo commented Jan 13, 2022 •
edited
Loading

Who could replace them?
Searching who contributed for this binding in 2021, I see @ardanedh as the most regular contributor.

@ardanedh @alexf2015 : is one of you knowing well the code of this binding. If this is the case, would you like to review future PRs?

@alexf2015
Copy link
Contributor Author

@lolodomo in fact I have never fully understood how this binding works. Especially I do not know the idea/concept behind it. It is very different from the approach I used in my bindings. But for sure my bindings lack autodiscovery and in addition rely on polling instead of event handling. This makes life easier...
To make it short, from a general perspective I could take part in reviews but I don't like to be the first contact, especially since there might be phases when I do not have any time at all to deal with openhab.

@ardanedh
Copy link
Contributor

Who could replace them? Searching who contributed for this binding in 2021, I see @ardanedh as the most regular contributor.

@ardanedh @alexf2015 : is one of you knowing well the code of this binding. If this is the case, would you like to review future PRs?

The codebase of the binding is huge - I've been rummaging around a bit and as @alexf2015 already mentioned, the original intent is difficult to grasp. In my opinion, there are too many digitalSTROM concepts realised in the binding - and that's exactly what I don't need when using openHAB.

I'm actively using the binding and I am willing to help keep it running. But after all, this is an open source project and no one can be forced to maintain business service level reaction times ;)

Obviously, digitalSTROM is working on a new API, which would justify a reimplementation of a (lean, DS concept free) digitalSTROM binding ...

@alexf2015
added support for DSUID in DSS response data while being compatible t…
7e02a5c 
…o removed DSID which might still be in use due to older firmware versions.

Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
fixed a NPE and also fixed json parameter naming.
734248e 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
Applied Spotless
fc34c66 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
changes due to review
858bf8f 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
@alexf2015
applied improvements from DSUID class
57cccd0 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
lolodomo
lolodomo approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

@ardanedh ; can you at least tell us if this PR looks good to you?

lolodomo added a commit that referenced this pull request Jan 13, 2022
@lolodomo
[digitalstrom] Update CODEOWNERS
42e8a81 
As discussed in #12033 , the mentioned authors for the digitalstrom binding will no more contribute or review.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo mentioned this pull request Jan 13, 2022
Merged
ardanedh
ardanedh approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@ardanedh ardanedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the trimmedDsuid, this looks fine to me as well ... thank you, @alexf2015!

.../openhab/binding/digitalstrom/internal/lib/structure/devices/deviceparameters/impl/DSID.java Outdated Show resolved Hide resolved
@alexf2015
fixed variable name, made dsid member final, added author
f525876 
Signed-off-by: Alexander Friese <af944580@googlemail.com>
jlaur pushed a commit that referenced this pull request Jan 14, 2022
@lolodomo
[digitalstrom] Update CODEOWNERS (#12041)
ae50e32 
As discussed in #12033 , the mentioned authors for the digitalstrom binding will no more contribute or review.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo merged commit 1ee5906 into openhab:main Jan 14, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jan 14, 2022
@alexf2015 alexf2015 deleted the digitalstrom-dev branch January 14, 2022 13:31
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
@lolodomo @moesterheld
[digitalstrom] Update CODEOWNERS (openhab#12041)
afd2766 
As discussed in openhab#12033 , the mentioned authors for the digitalstrom binding will no more contribute or review.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
moesterheld pushed a commit to moesterheld/openhab-addons that referenced this pull request Jan 18, 2022
@alexf2015 @moesterheld
[digitalstrom] Adoptions due to API changes in DSS Update 1.19.2 (ope…
13f3f39 
…nhab#12033)

* added support for DSUID in DSS response data while being compatible to removed DSID which might still be in use due to older firmware versions.
* fixed a NPE and also fixed json parameter naming.
* applied improvements from DSUID class
* fixed variable name, made dsid member final, added author

Signed-off-by: Alexander Friese <af944580@googlemail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@lolodomo
[digitalstrom] Update CODEOWNERS (openhab#12041)
bc6e60f 
As discussed in openhab#12033 , the mentioned authors for the digitalstrom binding will no more contribute or review.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@alexf2015
[digitalstrom] Adoptions due to API changes in DSS Update 1.19.2 (ope…
96844e4 
…nhab#12033)

* added support for DSUID in DSS response data while being compatible to removed DSID which might still be in use due to older firmware versions.
* fixed a NPE and also fixed json parameter naming.
* applied improvements from DSUID class
* fixed variable name, made dsid member final, added author

Signed-off-by: Alexander Friese <af944580@googlemail.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@lolodomo @NickWaterton
[digitalstrom] Update CODEOWNERS (openhab#12041)
b363d88 
As discussed in openhab#12033 , the mentioned authors for the digitalstrom binding will no more contribute or review.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@alexf2015 @NickWaterton
[digitalstrom] Adoptions due to API changes in DSS Update 1.19.2 (ope…
757e17a 
…nhab#12033)

* added support for DSUID in DSS response data while being compatible to removed DSID which might still be in use due to older firmware versions.
* fixed a NPE and also fixed json parameter naming.
* applied improvements from DSUID class
* fixed variable name, made dsid member final, added author

Signed-off-by: Alexander Friese <af944580@googlemail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@lolodomo @andan67
[digitalstrom] Update CODEOWNERS (openhab#12041)
2823ec2 
As discussed in openhab#12033 , the mentioned authors for the digitalstrom binding will no more contribute or review.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@alexf2015 @andan67
[digitalstrom] Adoptions due to API changes in DSS Update 1.19.2 (ope…
6136701 
…nhab#12033)

* added support for DSUID in DSS response data while being compatible to removed DSID which might still be in use due to older firmware versions.
* fixed a NPE and also fixed json parameter naming.
* applied improvements from DSUID class
* fixed variable name, made dsid member final, added author

Signed-off-by: Alexander Friese <af944580@googlemail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@lolodomo @andrasU
[digitalstrom] Update CODEOWNERS (openhab#12041)
c0e0bc3 
As discussed in openhab#12033 , the mentioned authors for the digitalstrom binding will no more contribute or review.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@alexf2015 @andrasU
[digitalstrom] Adoptions due to API changes in DSS Update 1.19.2 (ope…
e367961 
…nhab#12033)

* added support for DSUID in DSS response data while being compatible to removed DSID which might still be in use due to older firmware versions.
* fixed a NPE and also fixed json parameter naming.
* applied improvements from DSUID class
* fixed variable name, made dsid member final, added author

Signed-off-by: Alexander Friese <af944580@googlemail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@ardanedh ardanedh ardanedh approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

[digitalstrom] Power Consumption and Energy Level NULL after DSS Update to 1.19.2
5 participants
@alexf2015 @lolodomo @hmerk @ardanedh @jlaur