[homekit] use quantity type conversions for temperature characteristics #12083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if an Item associated with a temperature characteristic has a QuantityType (of dimension Temperature) as its state, regardless of current unit, use that to convert to celsius instead of any other configuration. Note that this is only for supply values to HomeKit; commands coming from HomeKit will still send a DecimalType with units according to the HomeKit-wide useFahrenheit configuration. Signed-off-by: Cody Cutrer <cody@cutrer.us>
|
LGTM |
yfre
approved these changes
Jan 22, 2022
lolodomo
added
the
enhancement
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…cs (openhab#12083) if an Item associated with a temperature characteristic has a QuantityType (of dimension Temperature) as its state, regardless of current unit, use that to convert to celsius instead of any other configuration. Note that this is only for supply values to HomeKit; commands coming from HomeKit will still send a DecimalType with units according to the HomeKit-wide useFahrenheit configuration. Signed-off-by: Cody Cutrer <cody@cutrer.us>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
…cs (openhab#12083) if an Item associated with a temperature characteristic has a QuantityType (of dimension Temperature) as its state, regardless of current unit, use that to convert to celsius instead of any other configuration. Note that this is only for supply values to HomeKit; commands coming from HomeKit will still send a DecimalType with units according to the HomeKit-wide useFahrenheit configuration. Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…cs (openhab#12083) if an Item associated with a temperature characteristic has a QuantityType (of dimension Temperature) as its state, regardless of current unit, use that to convert to celsius instead of any other configuration. Note that this is only for supply values to HomeKit; commands coming from HomeKit will still send a DecimalType with units according to the HomeKit-wide useFahrenheit configuration. Signed-off-by: Cody Cutrer <cody@cutrer.us>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…cs (openhab#12083) if an Item associated with a temperature characteristic has a QuantityType (of dimension Temperature) as its state, regardless of current unit, use that to convert to celsius instead of any other configuration. Note that this is only for supply values to HomeKit; commands coming from HomeKit will still send a DecimalType with units according to the HomeKit-wide useFahrenheit configuration. Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if an Item associated with a temperature characteristic has a QuantityType
(of dimension Temperature) as its state, regardless of current unit,
use that to convert to celsius instead of any other configuration.
Note that this is only for supply values to HomeKit; commands coming from
HomeKit will still send a DecimalType with units according to the HomeKit-wide
useFahrenheit configuration.