Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[voicerss] Fix bad audio format code and use HTTPS URL instead of HTTP #12092

Merged
merged 1 commit into from
Jan 22, 2022
Merged

[voicerss] Fix bad audio format code and use HTTPS URL instead of HTTP #12092

merged 1 commit into from
Jan 22, 2022

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Jan 22, 2022 •
edited
Loading

Fix #12091

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Jan 22, 2022
@lolodomo
Copy link
Contributor Author

@fwolter @jlaur : a fast review & merge would be appreciated as it fixed an annoying bug introduced by a PR I merged today.

@fwolter fwolter merged commit e9c9acd into openhab:main Jan 22, 2022
@fwolter fwolter added this to the 3.3 milestone Jan 22, 2022
@lolodomo
Copy link
Contributor Author

Thank you @fwolter

@lolodomo lolodomo deleted the voicerss_https branch January 22, 2022 18:15
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
@lolodomo
[voicerss] Fix bad audio format code and use HTTPS URL instead of HTTP (
7ce3184 
openhab#12092)

Fix openhab#12091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@lolodomo @NickWaterton
[voicerss] Fix bad audio format code and use HTTPS URL instead of HTTP (
22c930f 
openhab#12092)

Fix openhab#12091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@lolodomo @andan67
[voicerss] Fix bad audio format code and use HTTPS URL instead of HTTP (
935b848 
openhab#12092)

Fix openhab#12091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@lolodomo @andrasU
[voicerss] Fix bad audio format code and use HTTPS URL instead of HTTP (
3d64357 
openhab#12092)

Fix openhab#12091

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

@JochenHiller JochenHiller Awaiting requested review from JochenHiller

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

[voicerss] Wrong generated audio format code
2 participants
@lolodomo @fwolter