Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infokeydinrail] Initial contribution #12125

Closed
wants to merge 1 commit into from

Conversation

thanast
Copy link

@thanast thanast commented Jan 26, 2022

Infokey Din Rail Binding

This binding is designed to work with some custom made din rail boards based on chips MCP23017, MCP23008 and MCP3008. Also this binding tries to incomporate ready made solution for easy use of cheap sensors that sold in eBay and other networks.

@thanast thanast requested a review from a team as a code owner January 26, 2022 16:46
Comment on lines +9 to +17
<feature name="org.openhab.binding.infokeydinrail" description="openHAB Add-ons :: Bundles :: infokeydinrail Binding" version="3.3.0.SNAPSHOT">
<details>This project contains the official add-ons of openHAB</details>
<feature prerequisite="true" dependency="false">wrap</feature>
<bundle start-level="80">mvn:com.pi4j/pi4j-core/1.4</bundle>
<bundle start-level="80">mvn:javax.xml.bind/jaxb-api/2.3.1</bundle>
<bundle start-level="80">mvn:javax.activation/javax.activation-api/1.2.0</bundle>
<bundle start-level="80">wrap:mvn:com.pi4j/pi4j-gpio-extension/1.3</bundle>
<bundle start-level="80">wrap:mvn:org.lastnpe.eea/eea-all/2.2.1</bundle>
</feature>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this one. Remove it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it and tried to compile again and the result was the same!

Copy link
Member

@J-N-K J-N-K Jan 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove noEmbedDependency.profile. Why did you add that? It's usually wrong.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thanast look at the MCP23017 binding to see what you should use in the feature.xml and pom.xml. You don't need to include gson in the pom.xml and also should not use commons io preferably.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thanast look at the MCP23017 binding to see what you should use in the feature.xml and pom.xml. You don't need to include gson in the pom.xml and also should not use commons io preferably.

I uploaded this project just for your help. It is not in the phase that can be distributed or can be used. Also I would share the devices in the near future for anyone who will be interested. I have search the web also for issues with karaf and pi4j but nothing found. The intrested thing is that exit another binding called org.opehab.binding.mcp23017 that uses exactly the same libraries do compilation completely to my pc. I tried to copy the project rename it and recompile it compiles successfully. I cannot understand what I missing...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thanast look at the MCP23017 binding to see what you should use in the feature.xml and pom.xml. You don't need to include gson in the pom.xml and also should not use commons io preferably.

I uploaded this project just for your help. It is not in the phase that can be distributed or can be used. Also I would share the devices in the near future for anyone who will be interested. I have search the web also for issues with karaf and pi4j but nothing found. The intrested thing is that exit another binding called org.opehab.binding.mcp23017 that uses exactly the same libraries do compilation completely to my pc. I tried to copy the project rename it and recompile it compiles successfully. I cannot understand what I missing...

Thank you Hilbrand greetings to The Netherlands from my wife who is Dutch!

@Hilbrand Hilbrand added the work in progress A PR that is not yet ready to be merged label Jan 26, 2022
@lolodomo lolodomo changed the title Initial Commit [infokeydinrail] Initial contribution Jan 26, 2022
@Hilbrand
Copy link
Member

I've added the work-in-progress label to indicatie this binding needs more work before it should be reviewed (missing readme and lots of commented out code, also misses from the bundle pom.xml).
I was just wondering are these newly developed devies? Looks interesting, but I couldn't find anyrhing in the internet about this.
An additional remark. The pi4j library v1 is deprecated and basically a dead end imoh (they're developing a new version, but that doesn't seem to have extended support, so I don't know how well it supports ic like the MCP23017 out of the box.) Using this old version 1 might be a problem in the future (If I have it correct the underlying library pi4j depends on is not maintened anymore) and could mean this binding won't work anymore. Just something to consider developing this binding..

@lolodomo lolodomo added the new binding If someone has started to work on a binding. For a new binding PR. label Jan 27, 2022
<parent>
<groupId>org.openhab.addons.bundles</groupId>
<artifactId>org.openhab.addons.reactor.bundles</artifactId>
<version>3.3.0-SNAPSHOT</version>
Copy link
Member

@wborn wborn Jul 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>3.3.0-SNAPSHOT</version>
<version>4.2.0-SNAPSHOT</version>

@@ -0,0 +1,13 @@
This content is produced and maintained by the openHAB project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be adapted to the new addon.xml, the PR to adapt the developer docs is not merged yet, so if you need more details, the corresponding issue is here: openhab/openhab-core#2058
But you can also update your branch and look at another binding's addon.xml and adapt it to this initial contribution.

@lsiepel lsiepel added stale As soon as a PR is marked stale, it can be removed 6 months later. awaiting feedback Awaiting feedback from the pull request author labels Jan 16, 2023
@stale stale bot removed the stale As soon as a PR is marked stale, it can be removed 6 months later. label Jan 16, 2023
@lsiepel
Copy link
Contributor

lsiepel commented Nov 15, 2023

@thanast are you able to proceed with this PR? If you abandon this PR, it might be better to close it.

@lsiepel lsiepel added the stale As soon as a PR is marked stale, it can be removed 6 months later. label Apr 29, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Jun 15, 2024

Unfortunately it looks like we cannot bring this PR to the finish line. After two years of inactivity i close this PR. If there is a need to restart, feel free to re-open or start a new PR.

@lsiepel lsiepel closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting feedback Awaiting feedback from the pull request author new binding If someone has started to work on a binding. For a new binding PR. stale As soon as a PR is marked stale, it can be removed 6 months later. work in progress A PR that is not yet ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants