[actiontemplatehli] Initial contribution

[GiviMAD]

NOTE: This interpreter was renamed from 'opennlphli' to 'actiontemplatehli' to avoid confusion.
This add-on adds an human language interpreter powered by openNLP that allows the user to define their own actions to read from items or send commands to them. Also supports to configure a fallback interpreter, so you can use this one just to complement another.
Aims to be compatible with all languages and assumes the action templates are written in the configured openHAB language.
Supported feature list and samples are provided on the readme.
I hope that the community find it useful, for me is a solution for the custom commands I wanted to add to the standard interpreter.

[GiviMAD]

@lolodomo I think the initial version is ready in case you want to give it a try, for me it work pretty well using Spanish.
I will add a post on the forum tomorrow to see if someone is interested on going testing it.
I just need to add some rule actions to allow to take advance of the interpreter features from there.
Also I will try to add some tests before removing the WIP.
Also I think this should be changed for the non response mode to work correctly openhab/openhab-core#2780

[GiviMAD]

I think is not possible to expose actions from this kind of add-on, I will let that for the future.

[GiviMAD]

when you have time, it's ready for review!

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/some-new-voice-add-ons-porcupineks-googlestt-watsonstt-voskstt/133500/1

[GiviMAD]

@lolodomo, can you remove the work in progress label? Thank you in advance.

[GiviMAD]

I have updated how getSupportedLocale works, and renamed the 'ruleMode' option to 'silence'.

Let me know whenever you have time to start reviewing this one, and thanks for the effort.

[GiviMAD]

Another difficulty is that for requesting the temperature in the bedroom, in French we have at least 2 natural ways to request it, either "quelle est la température dans la chambre ? " and "quelle température fait-il dans la chambre ? ". If my item label is "température dans la chambre", I don't think there is a way to make the current interpreter matching my second request.

For this kind of situation I think you can use an action that matches groups with tag 'location' and filter the member targets by another tag that is only on the temperature items. This way the itemLabel will be the group name (room name).

[GiviMAD]

I will try playing with this interpreter next weekend.
IMHO, something important is missing. Everything is mainly based on items label. The problem is that, due to UI constraints on mobile phones, the item label you define is generally a short label and not the one you will use when speaking. As an example, for temperature in the bedroom, my item label could be in French "Température chambre" but when speaking I will use "température dans la chambre". This was solved with other voice assistants (google and Amazon) with the ability to define for each item the label to consider by the assistant (replacing the OH label). I believe we should have this feature also for this interpreter.

Right now you can add synonyms to the items and those will be also considered as valid values for the itemLabel placeholder.

[lolodomo]

Right now you can add synonyms to the items and those will be also considered as valid values for the itemLabel placeholder.

Ok, will try that.

[lolodomo]

There are still few cases where you use a method parameter to set it to a new value inside the method.
Could you fix these few cases ?

Except that, I will have to check again my old review comments (mainly relative to documentation and settings) and make if possible few tests.
I think we are in time for a possible merge tomorrow.

[GiviMAD]

There are still few cases where you use a method parameter to set it to a new value inside the method. Could you fix these few cases ?

I didn't have that warning enabled on the IDE.
Must be corrected now.
Let me know for anything else.

[GiviMAD]

@lolodomo, is there something pending in this one?

[lolodomo]

@lolodomo, is there something pending in this one?

Just one improvement to do in the documentation and a question to answer.

I will not have time to test it today. I will merge today as soon as you will give a feedback to these 2 last comments.
I will probably then test it during the next week.

[lolodomo]

Thank you for the tests.

[GiviMAD]

Thank you for the tests.

Never added tests in a binding before, but they were really useful for me while implementing the latest features.

[lolodomo]

LGTM, thank you