Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[somneo] Initial contribution #12321

Merged
merged 5 commits into from
Jul 27, 2022
Merged

[somneo] Initial contribution #12321

merged 5 commits into from
Jul 27, 2022

Conversation

myrck
Copy link
Contributor

@myrck myrck commented Feb 19, 2022

Signed-off-by: Michael Myrcik michael.myrcik@web.de

This binding integrates Philips Somneo HF3670/60 into openHAB.
By using the HTTP API provided by the device.

JAR: https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.somneo/3.3.0-SNAPSHOT/org.openhab.binding.somneo-3.3.0-SNAPSHOT.jar

Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
@myrck myrck requested a review from a team as a code owner February 19, 2022 14:52
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/new-binding-philips-somneo-hf3670-connected-sleep-and-wake-up-light/133464/1

@jlaur jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Feb 19, 2022
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! The code already looks really good, I have only added some minor comments.

myrck added 2 commits July 24, 2022 18:02
Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
@jlaur
Copy link
Contributor

jlaur commented Jul 26, 2022

@0x4d4d - you have marked some comments as resolved, but I don't see any related changes committed (and pushed)?

Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
@myrck myrck requested a review from jlaur July 26, 2022 21:29
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted just one more occurrence of specific model number mentioned.

bundles/org.openhab.binding.somneo/README.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

@jlaur jlaur merged commit 3b8567b into openhab:main Jul 27, 2022
@jlaur jlaur added this to the 3.4 milestone Jul 27, 2022
@lolodomo
Copy link
Contributor

The German translations have to be uploaded in Crowdin.

@jlaur
Copy link
Contributor

jlaur commented Jul 27, 2022

@lolodomo - I'll do that. Missed it when picking up the PR again.

@jlaur
Copy link
Contributor

jlaur commented Jul 27, 2022

@lolodomo - done. @0x4d4d - you can now apply missing translations in Crowdin. After that, they will be synced back to the repository. See: https://www.openhab.org/docs/developer/utils/i18n.html#managing-translations

leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
* [somneo] Initial contribution

Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [somneo] Initial contribution

Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* [somneo] Initial contribution

Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [somneo] Initial contribution

Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [somneo] Initial contribution

Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants