-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[somneo] Initial contribution #12321
Conversation
Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! The code already looks really good, I have only added some minor comments.
...binding.somneo/src/main/java/org/openhab/binding/somneo/internal/SomneoBindingConstants.java
Show resolved
Hide resolved
....openhab.binding.somneo/src/main/java/org/openhab/binding/somneo/internal/SomneoHandler.java
Show resolved
Hide resolved
....openhab.binding.somneo/src/main/java/org/openhab/binding/somneo/internal/SomneoHandler.java
Outdated
Show resolved
Hide resolved
....openhab.binding.somneo/src/main/java/org/openhab/binding/somneo/internal/SomneoHandler.java
Outdated
Show resolved
Hide resolved
....openhab.binding.somneo/src/main/java/org/openhab/binding/somneo/internal/SomneoHandler.java
Outdated
Show resolved
Hide resolved
....openhab.binding.somneo/src/main/java/org/openhab/binding/somneo/internal/SomneoHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
@0x4d4d - you have marked some comments as resolved, but I don't see any related changes committed (and pushed)? |
Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted just one more occurrence of specific model number mentioned.
Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website
The German translations have to be uploaded in Crowdin. |
@lolodomo - I'll do that. Missed it when picking up the PR again. |
@lolodomo - done. @0x4d4d - you can now apply missing translations in Crowdin. After that, they will be synced back to the repository. See: https://www.openhab.org/docs/developer/utils/i18n.html#managing-translations |
* [somneo] Initial contribution Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
* [somneo] Initial contribution Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
* [somneo] Initial contribution Signed-off-by: Michael Myrcik <michael.myrcik@web.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* [somneo] Initial contribution Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
* [somneo] Initial contribution Signed-off-by: Michael Myrcik <michael.myrcik@web.de>
Signed-off-by: Michael Myrcik michael.myrcik@web.de
This binding integrates Philips Somneo HF3670/60 into openHAB.
By using the HTTP API provided by the device.
JAR: https://openhab.jfrog.io/artifactory/libs-pullrequest-local/org/openhab/addons/bundles/org.openhab.binding.somneo/3.3.0-SNAPSHOT/org.openhab.binding.somneo-3.3.0-SNAPSHOT.jar