[daikin] Fix Special Mode and Streamer support #12324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
jimtng
force-pushed
the
daikin-streamer
branch
from
1193bc4 to
73c3dcb
Compare
jimtng
changed the title
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
daikin-streamer
branch
from
73c3dcb to
adfd120
Compare
lolodomo
added
the
enhancement
lolodomo
requested changes
Feb 23, 2022
.../org.openhab.binding.daikin/src/main/java/org/openhab/binding/daikin/internal/api/Enums.java
Outdated
Show resolved
Hide resolved
...ding.daikin/src/main/java/org/openhab/binding/daikin/internal/handler/DaikinBaseHandler.java
Outdated
Show resolved
Hide resolved
|
This is a breaking change to be explained in release notes. |
Where is the "Release notes"? Is it something for the openhab maintainer (i.e. not me) to do? |
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Look at this example: openhab/openhab-distro#1369 |
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
* [daikin] Fix Special Mode support Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
* [daikin] Fix Special Mode support Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [daikin] Fix Special Mode support Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [daikin] Fix Special Mode support Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [daikin] Fix Special Mode support Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Daikin models have the ability to set
Currently:
specialmodereports the current combination of modes set on the device: streamer / eco_streamer / powerful_streamer / eco / powerful / offspecialmode-powerfulchannelThis PR introduced the following changes:
specialmodechannel now only reports NORMAL/ECO/POWERFUL, removing Streamer from this channel. This greatly simplifies the usage for this channel.specialmodechannel is changed from Read-only to Read/writespecialmode-powerfulchannel is removed, since setting the powerful mode can now be done through thespecialmodechannelstreameris introduced to set the streamer modeThis makes the two features (streamer and normal/eco/powerful) more straight forward to deal with.
The issue / feature was reported/requested and tested here:
https://community.openhab.org/t/daikin-the-channel-specialmode-can-be-read-but-not-modified-from-oh-both-2-5-12-and-3-1/125561