-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt] Add default translations #12328
Conversation
This will allow for translating the MQTT Binding in Crowdin. Signed-off-by: Wouter Born <github@maindrain.net>
@@ -1,3 +1,20 @@ | |||
# thing types | |||
|
|||
thing-type.mqtt.cct.label = Milight CCT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused about this line in this module but if that is fine LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MQTT Binding also has a bundle for integrating an open source based Milight hub using MQTT (see add-on docs).
This is what all MQTT Binding things look like in the UI 🙂
Just one question: due to the lack of files binding.xml, there is no bindings label/description to internationalize. Is it expected ? |
Yes it's one binding consisting of several bundles. The binding.xml file is already translated in the org.openhab.binding.mqtt bundle. |
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This will allow for translating the MQTT Binding in Crowdin. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
This will allow for translating the MQTT Binding in Crowdin. Signed-off-by: Wouter Born <github@maindrain.net>
This will allow for translating the MQTT Binding in Crowdin. Signed-off-by: Wouter Born <github@maindrain.net>
This will allow for translating the MQTT Binding in Crowdin. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
This will allow for translating the MQTT Binding in Crowdin. Signed-off-by: Wouter Born <github@maindrain.net>
This will allow for translating the MQTT Binding in Crowdin.
Fixes #12220