Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt] Add default translations #12328

Merged
merged 1 commit into from
Feb 20, 2022
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented Feb 20, 2022

This will allow for translating the MQTT Binding in Crowdin.

Fixes #12220

This will allow for translating the MQTT Binding in Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team February 20, 2022 15:32
@@ -1,3 +1,20 @@
# thing types

thing-type.mqtt.cct.label = Milight CCT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused about this line in this module but if that is fine LGTM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MQTT Binding also has a bundle for integrating an open source based Milight hub using MQTT (see add-on docs).

This is what all MQTT Binding things look like in the UI 🙂

Screenshot from 2022-02-20 16-55-32

@lolodomo
Copy link
Contributor

Just one question: due to the lack of files binding.xml, there is no bindings label/description to internationalize. Is it expected ?

@wborn
Copy link
Member Author

wborn commented Feb 20, 2022

Yes it's one binding consisting of several bundles. The binding.xml file is already translated in the org.openhab.binding.mqtt bundle.

@lolodomo
Copy link
Contributor

Yes it's one binding consisting of several bundles. The binding.xml file is already translated in the org.openhab.binding.mqtt bundle.

OK

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 8559651 into openhab:main Feb 20, 2022
@lolodomo lolodomo added this to the 3.3 milestone Feb 20, 2022
@wborn wborn deleted the mqtt-translations branch February 20, 2022 19:12
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
This will allow for translating the MQTT Binding in Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
This will allow for translating the MQTT Binding in Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
This will allow for translating the MQTT Binding in Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
This will allow for translating the MQTT Binding in Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
This will allow for translating the MQTT Binding in Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mqtt.generic] There is not yet any default translation properties file.
3 participants