-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[homekit] add support for complex accessories #12346
Conversation
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Signed-off-by: Eugen Freiter <freiter@gmx.de>
@andylintner @lolodomo im afraid, UI configurations that are not supported by the binding could confuse users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only few typo
....openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitChangeListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Eugen Freiter <freiter@gmx.de>
thank you lolodomo for the review. |
Hi @yfre can you post an example of Valve grouping which are already in a group ?
|
so, if you want to get something like this then this is currently not possible. this requires one more accessory type called "IrrigationSystem" which is not supported by homekit binding yet. i have it on my todo list. |
thank you, |
multiple accessories of the same type is currently not supported. here we would need to have support group of groups as discussed here something like this
it still looks complex to me but i dont have any better ideas for complex items of the same type |
* Add complex accessories Signed-off-by: Eugen Freiter <freiter@gmx.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
* Add complex accessories Signed-off-by: Eugen Freiter <freiter@gmx.de>
* Add complex accessories Signed-off-by: Eugen Freiter <freiter@gmx.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* Add complex accessories Signed-off-by: Eugen Freiter <freiter@gmx.de>
HomeKit accessory can be combination of multiple accessories, e.g. fan with light, sensor with battery, irrigation with multiple valves
iOS home app would show such complex accessory as one tile on the home screen that opens a view with multiple controls.
this PR adds support for such complex accessories.
in openHAB complex accessory would be modelled by adding additional HomeKit tag to the group metadata, e.g.
it is backward compatible. all existing HomeKit configurations have only one tag at group level and should work as before.