-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plugwiseha] Fix bug introduced with #12349 #12366
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
changed the title
[plugwiseha] Fix bug introduced with #12349
[plugwiseha][WIP] Fix bug introduced with #12349
Feb 24, 2022
lsiepel
changed the title
[plugwiseha][WIP] Fix bug introduced with #12349
[plugwiseha] Fix bug introduced with #12349
Feb 25, 2022
lolodomo
requested changes
Feb 25, 2022
...a/src/main/java/org/openhab/binding/plugwiseha/internal/handler/PlugwiseHABridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lolodomo
approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
* Fix bug introduced with openhab#12349 Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jun 29, 2022
* Fix bug introduced with openhab#12349 Signed-off-by: Leo Siepel <leosiepel@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Fix bug introduced with openhab#12349 Signed-off-by: Leo Siepel <leosiepel@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Fix bug introduced with openhab#12349 Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Fix bug introduced with openhab#12349 Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry @lolodomo i should have paid more attention to your comment about the StringType returning null in my previous PR. I thought it was fine. When testing i had no problems, but after some user feedback we discovered some situations that it does lead to a problem.