Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugwiseha] Fix bug introduced with #12349 #12366

Merged
merged 8 commits into from
Feb 25, 2022

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 24, 2022

Sorry @lolodomo i should have paid more attention to your comment about the StringType returning null in my previous PR. I thought it was fine. When testing i had no problems, but after some user feedback we discovered some situations that it does lead to a problem.

@lsiepel lsiepel changed the title [plugwiseha] Fix bug introduced with #12349 [plugwiseha][WIP] Fix bug introduced with #12349 Feb 24, 2022
@lsiepel lsiepel changed the title [plugwiseha][WIP] Fix bug introduced with #12349 [plugwiseha] Fix bug introduced with #12349 Feb 25, 2022
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Feb 25, 2022
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit da0234f into openhab:main Feb 25, 2022
@lolodomo lolodomo added this to the 3.3 milestone Feb 25, 2022
@lsiepel lsiepel deleted the plugwiseha-improvements branch March 21, 2022 21:27
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jun 29, 2022
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* Fix bug introduced with openhab#12349

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants