[wemo] Refactor Insight Switch parser #12380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
force-pushed
the
12105-wemo-insight-parser-class
branch
from
4152ea2 to
b30c1a4
Compare
lolodomo
requested changes
Feb 27, 2022
.../org.openhab.binding.wemo/src/main/java/org/openhab/binding/wemo/internal/InsightParser.java
Show resolved
Hide resolved
.../org.openhab.binding.wemo/src/main/java/org/openhab/binding/wemo/internal/InsightParser.java
Outdated
Show resolved
Hide resolved
...binding.wemo/src/main/java/org/openhab/binding/wemo/internal/handler/WemoInsightHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
* Extract Insight parser to separate class and provide unit tests Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Extract Insight parser to separate class and provide unit tests Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Extract Insight parser to separate class and provide unit tests Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Extract Insight parser to separate class and provide unit tests Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12105
Continuation of #12120
Signed-off-by: Jacob Laursen jacob-github@vindvejr.dk
Refactoring: Parsing of WeMo Insight Switch data string has been extracted to separate class:
NumberFormatException.