Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wemo] Simplify getWemoURL usages in handlers #12397

Merged
merged 1 commit into from
Mar 2, 2022
Merged

[wemo] Simplify getWemoURL usages in handlers #12397

merged 1 commit into from
Mar 2, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Mar 1, 2022

  • Consolidate host initialization/caching in WemoBaseThingHandler.
  • Simplify usage of getWemoURL and remove redundant error handling.

@jlaur
Simplify getWemoURL usages in handlers
a53c81d 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from hmerk as a code owner March 1, 2022 23:36
hmerk
hmerk approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@hmerk hmerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lolodomo
lolodomo approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 93e3a71 into openhab:main Mar 2, 2022
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Mar 2, 2022
@lolodomo lolodomo added this to the 3.3 milestone Mar 2, 2022
@jlaur jlaur linked an issue Mar 2, 2022 that may be closed by this pull request
[wemo] Refactoring code duplication #12100
Closed
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@jlaur @NickWaterton
Simplify getWemoURL usages in handlers (openhab#12397)
5bdde04 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
@jlaur jlaur deleted the 12100-wemo-get-url-refactoring branch June 13, 2022 16:47
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@jlaur @andan67
Simplify getWemoURL usages in handlers (openhab#12397)
2c6355c 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@jlaur @andrasU
Simplify getWemoURL usages in handlers (openhab#12397)
002a125 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@jlaur @psmedley
Simplify getWemoURL usages in handlers (openhab#12397)
6f2ac70 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@hmerk hmerk hmerk approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

[wemo] Refactoring code duplication
3 participants
@jlaur @hmerk @lolodomo