Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openwebnet] handle Thermo Central Unit monitoring messages #12485

Merged
merged 7 commits into from
Mar 18, 2022
Merged

[openwebnet] handle Thermo Central Unit monitoring messages #12485

merged 7 commits into from
Mar 18, 2022

Conversation

aconte80
Copy link
Contributor

@aconte80 aconte80 commented Mar 16, 2022 •
edited
Loading

Enhance OpenWebNet binding to support thermoregulation with 4/99 zone central unit, e.g. BTicino 3550 model.

The Central Unit provides some information on the on-board display:

  • at least one probe in OFF mode (WHAT = AT_LEAST_ONE_PROBE_OFF)
  • at least one probe in PROTECTION mode (WHAT = AT_LEAST_ONE_PROBE_ANTIFREEZE)
  • at least one probe in MANUAL mode (WHAT = AT_LEAST_ONE_PROBE_MANUAL)
  • a generic FAILURE was detected on the system (WHAT = FAILURE_DISCOVERED)

For each case a specific read-only channel was added.

@aconte80 aconte80 requested a review from mvalla as a code owner March 16, 2022 18:13
@lolodomo
Copy link
Contributor

Conflicts to be resolved first.

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Mar 16, 2022
@mvalla mvalla changed the title [openwebnet] handle monitoring messages [openwebnet] handle Thermo Central Unit monitoring messages Mar 16, 2022
@aconte80 aconte80 force-pushed the dev-3.3-thermo-whats branch from 6d2aef4 to 976492d Compare March 17, 2022 11:06
@lolodomo
Copy link
Contributor

@mvalla : is it ok for you ?

lolodomo
lolodomo approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mvalla
mvalla requested changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@mvalla mvalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only change the capital OFF in the name of the channel, just to make it similar to the other channels. For the rest it looks good, excellent improvement thanks!

bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusThermoCentralUnit.xml Outdated Show resolved Hide resolved
...webnet/src/main/java/org/openhab/binding/openwebnet/internal/OpenWebNetBindingConstants.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.openwebnet/README.md Outdated Show resolved Hide resolved
aconte80 and others added 6 commits March 18, 2022 10:50
@aconte80
- handled what=30 (failure discovered ), what=22 (at least 1 probe in…
95779c9 
… off), what=23 (at least 1 probe in protection), what=24 (at least 1 probe in manual)

- related channels added

Signed-off-by: Conte Andrea <andrea@conte.com>
@aconte80
- update README
49516a5 
- ignore messages from probes and central unit and keep track only of messages from a real thermostat

Signed-off-by: Conte Andrea <andrea@conte.com>
@aconte80
resolve merge confilcts and moved a comment
a22205f 
Signed-off-by: Conte Andrea <andrea@conte.com>
@aconte80
changes as required by the review
8f3ff2d 
Signed-off-by: Conte Andrea <andrea@conte.com>
@aconte80
add example of failureDiscovered channel
a74835c 
Signed-off-by: Conte Andrea <andrea@conte.com>
@aconte80 @mvalla
Update bundles/org.openhab.binding.openwebnet/src/main/resources/OH-I…
3b702c0 
…NF/thing/channels.xml

Co-authored-by: M Valla <12682715+mvalla@users.noreply.github.com>
Signed-off-by: Conte Andrea <andrea@conte.com>
@aconte80 aconte80 force-pushed the dev-3.3-thermo-whats branch from 453c9d9 to 3b702c0 Compare March 18, 2022 09:51
@aconte80
changed capital letters (atLeastOneProbeOFF -> atLeatOneProbeOff) as …
4f0e78d 
…suggested

Signed-off-by: Conte Andrea <andrea@conte.com>
@aconte80
Copy link
Contributor Author

@mvalla I've updated string upper/lowercase as suggested

@mvalla
Copy link
Contributor

mvalla commented Mar 18, 2022

ok. @lolodomo: his LGTM and for me can be merged

@lolodomo lolodomo merged commit 1918afc into openhab:main Mar 18, 2022
@lolodomo lolodomo added this to the 3.3 milestone Mar 18, 2022
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@aconte80 @NickWaterton
[openwebnet] handle Thermo Central Unit monitoring messages (openhab#…
2ebd8d9 
…12485)

* - handled what=30 (failure discovered ), what=22 (at least 1 probe in off), what=23 (at least 1 probe in protection), what=24 (at least 1 probe in manual)
- related channels added
* - update README
- ignore messages from probes and central unit and keep track only of messages from a real thermostat
* add example of failureDiscovered channel
* Update bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml
* changed capital letters (atLeastOneProbeOFF -> atLeatOneProbeOff) as suggested

Signed-off-by: Conte Andrea <andrea@conte.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@aconte80 @andan67
[openwebnet] handle Thermo Central Unit monitoring messages (openhab#…
9e9d0e3 
…12485)

* - handled what=30 (failure discovered ), what=22 (at least 1 probe in off), what=23 (at least 1 probe in protection), what=24 (at least 1 probe in manual)
- related channels added
* - update README
- ignore messages from probes and central unit and keep track only of messages from a real thermostat
* add example of failureDiscovered channel
* Update bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml
* changed capital letters (atLeastOneProbeOFF -> atLeatOneProbeOff) as suggested

Signed-off-by: Conte Andrea <andrea@conte.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@aconte80 @andrasU
[openwebnet] handle Thermo Central Unit monitoring messages (openhab#…
54c0d7d 
…12485)

* - handled what=30 (failure discovered ), what=22 (at least 1 probe in off), what=23 (at least 1 probe in protection), what=24 (at least 1 probe in manual)
- related channels added
* - update README
- ignore messages from probes and central unit and keep track only of messages from a real thermostat
* add example of failureDiscovered channel
* Update bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml
* changed capital letters (atLeastOneProbeOFF -> atLeatOneProbeOff) as suggested

Signed-off-by: Conte Andrea <andrea@conte.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@aconte80 @psmedley
[openwebnet] handle Thermo Central Unit monitoring messages (openhab#…
7f8db86 
…12485)

* - handled what=30 (failure discovered ), what=22 (at least 1 probe in off), what=23 (at least 1 probe in protection), what=24 (at least 1 probe in manual)
- related channels added
* - update README
- ignore messages from probes and central unit and keep track only of messages from a real thermostat
* add example of failureDiscovered channel
* Update bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml
* changed capital letters (atLeastOneProbeOFF -> atLeatOneProbeOff) as suggested

Signed-off-by: Conte Andrea <andrea@conte.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvalla mvalla mvalla requested changes

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@aconte80 @lolodomo @mvalla