-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[somfytahoma] added support for the Shutter thing #12495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octa22
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Mar 19, 2022
lolodomo
reviewed
Mar 20, 2022
...rc/main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaShutterHandler.java
Outdated
Show resolved
Hide resolved
octa22
force-pushed
the
somfytahoma-binding-pr
branch
from
March 24, 2022 22:05
bb771e2
to
bb5f902
Compare
lolodomo
reviewed
Mar 25, 2022
...rc/main/java/org/openhab/binding/somfytahoma/internal/handler/SomfyTahomaShutterHandler.java
Outdated
Show resolved
Hide resolved
octa22
force-pushed
the
somfytahoma-binding-pr
branch
from
March 27, 2022 08:51
bb5f902
to
25644a1
Compare
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
octa22
force-pushed
the
somfytahoma-binding-pr
branch
from
March 27, 2022 16:12
25644a1
to
22359dc
Compare
lolodomo
approved these changes
Mar 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Apr 27, 2022
Signed-off-by: Ondrej Pecta <opecta@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Ondrej Pecta <opecta@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for the Shutter thing as requested here:
#12458
and more over it fixes the functionality for simple dynamic venetian blinds which is discussed here:
https://community.openhab.org/t/re-somfy-tahoma-binding-not-working-properly-with-new-somfy-connectivity-kit/133969/14
Signed-off-by: Ondrej Pecta opecta@gmail.com