-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[knx] Handle exceptions during initial read #12520
Conversation
factored out from #12434 |
...hab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/AbstractKNXClient.java
Outdated
Show resolved
Hide resolved
...hab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/AbstractKNXClient.java
Outdated
Show resolved
Hide resolved
...hab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/AbstractKNXClient.java
Outdated
Show resolved
Hide resolved
@jlaur : please take the lead to review this PR, your comments are more detailed than mine. |
c969559
to
7f62dde
Compare
7f62dde
to
2af993a
Compare
@jlaur I had a closer look into the implementation of the Calimero library. The function called in the
So I now changed the code do catch any exception. The rationale behind it is as follows: any exception will end all scheduled reads, as the scheduled job ends. Catching exceptions and printing error messages is the approach, as it only skips the one faulty DP and continues for all others. |
fixes openhab#7239 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2af993a
to
584d6da
Compare
Thanks for following up on this. I think it's fine, since you are calling an external library you have no control over. So you need to encapsulate the risk of anything than can happen outside your boundary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
fixes openhab#7239 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
fixes openhab#7239 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
fixes openhab#7239 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
fixes openhab#7239 Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
fixes #7239
Signed-off-by: Holger Friedrich mail@holger-friedrich.de