Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[denonmarantz] Remove Apache StringUtils #12526

Merged
merged 1 commit into from
Mar 27, 2022

Conversation

mlobstein
Copy link
Contributor

Remove usage of org.apache.commons.lang3.StringUtils per #7722

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein requested a review from jwveldhuis as a code owner March 26, 2022 15:36
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jlaur
Copy link
Contributor

jlaur commented Mar 27, 2022

@wborn - looks good to me also. Can we merge?

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn
Copy link
Member

wborn commented Mar 27, 2022

Yes let's merge it now it has been checked by more eyes. 🙂

@wborn wborn merged commit 80cb1ed into openhab:main Mar 27, 2022
@wborn wborn added this to the 3.3 milestone Mar 27, 2022
@mlobstein mlobstein deleted the denon_removeApache branch March 27, 2022 13:27
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants