[orbitbhyve] do not update status of a disabled sprinker #12679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
|
Interesting, I imagine there is the same issue in many other bindings. |
|
@octa22 : in fact, I have two questions. |
|
Yes, what I was experiencing was an ONLINE thing with a handler, but only constructor was called, no initialization. After an investigation I found that the sprinkler was disabled, but the bridge set its status to ONLINE according to a cloud status. |
Thank you for your fast answer. It makes sense. |
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
Signed-off-by: Ondrej Pecta <opecta@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a rare bug when the bridge sets the sprinkler's status to ONLINE/OFFLINE even if the sprinkler is disabled.
Signed-off-by: Ondrej Pecta opecta@gmail.com