Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openweathermap] Fix display of alert data #12697

Merged
merged 3 commits into from
May 7, 2022

Conversation

boehan
Copy link
Contributor

@boehan boehan commented May 7, 2022

Signed-off-by: Hans Böhm h.boehm@gmx.at

This fixes an issue where the last alert in the API response is always ignored. Also discussed in the forum.

Signed-off-by: Hans Böhm <h.boehm@gmx.at>
@boehan boehan requested a review from cweitkamp as a code owner May 7, 2022 16:02
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openweathermap-new-one-call-api/101419/47

@boehan boehan added the bug An unexpected problem or unintended behavior of an add-on label May 7, 2022
Signed-off-by: Hans Böhm <h.boehm@gmx.at>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Hans Böhm <h.boehm@gmx.at>
@boehan
Copy link
Contributor Author

boehan commented May 7, 2022

Just noticed that javadoc for updateMinutelyForecastChannel was missing --> added

@lolodomo lolodomo merged commit cb60d89 into openhab:main May 7, 2022
@lolodomo
Copy link
Contributor

lolodomo commented May 7, 2022

Thank you

@lolodomo lolodomo added this to the 3.3 milestone May 7, 2022
@boehan boehan deleted the owm_fix_alerts branch May 7, 2022 17:04
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openweathermap-new-one-call-api/101419/50

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* fix display of alert data
* improve javadoc
* add javadoc to updateMinutelyForecastChannel

Signed-off-by: Hans Böhm <h.boehm@gmx.at>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* fix display of alert data
* improve javadoc
* add javadoc to updateMinutelyForecastChannel

Signed-off-by: Hans Böhm <h.boehm@gmx.at>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* fix display of alert data
* improve javadoc
* add javadoc to updateMinutelyForecastChannel

Signed-off-by: Hans Böhm <h.boehm@gmx.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants