Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[netatmo] Fix getActiveChildren #12830

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented May 27, 2022

Wait for the thing being initialized properly by the thing manager
before considering it as an active children for the bridge.

Fix #12809

Signed-off-by: Laurent Garnier lg.hc@free.fr

Wait for the thing being initialized properly by the thing manager
before considering it as an active children

Fix openhab#12809

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label May 27, 2022
@lolodomo
Copy link
Contributor Author

@jlaur : it fixes the not proper transitions we both saw at thing initialization.
Previously: OFFLINE/BRIDGE_OFFLINE => ONLINE => UNKNOWN => ONLINE
Now: OFFLINE/BRIDGE_OFFLINE => UNKNOWN => ONLINE

@jlaur
Copy link
Contributor

jlaur commented May 27, 2022

@lolodomo - thanks, I've just tested it and I can no longer reproduce the problem. Also the additional dispose/initialize is gone, but not sure if related.

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 1aeaccf into openhab:main May 27, 2022
@jlaur jlaur added this to the 3.3 milestone May 27, 2022
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on and removed enhancement An enhancement or new feature for an existing add-on labels May 27, 2022
@lolodomo lolodomo deleted the netatmo_getActiveChildren branch May 27, 2022 17:49
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
Wait for the thing being initialized properly by the thing manager
before considering it as an active children

Fix openhab#12809

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Wait for the thing being initialized properly by the thing manager
before considering it as an active children

Fix openhab#12809

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Wait for the thing being initialized properly by the thing manager
before considering it as an active children

Fix openhab#12809

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Wait for the thing being initialized properly by the thing manager
before considering it as an active children

Fix openhab#12809

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[netatmo] Strange startup behavior and status transitions
2 participants