Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tado] Automatically reconnect offline Things if possible #12868

Merged
merged 8 commits into from
Jun 4, 2022
Merged

[tado] Automatically reconnect offline Things if possible #12868

merged 8 commits into from
Jun 4, 2022

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Jun 3, 2022 •
edited
Loading

The Bridge will now automatically try to reconnect Things that went offline due to a communication error.

Fixes #12704 as follows

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

andrewfg added 2 commits June 3, 2022 16:43
@andrewfg
[tado] reconnect offline things if possible & allowed
ea49a4c 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[tado] read me
3559e2a 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added the enhancement An enhancement or new feature for an existing add-on label Jun 3, 2022
@andrewfg andrewfg requested a review from jlaur June 3, 2022 16:13
jlaur
jlaur requested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have posted some feedback, where half is perhaps only some clarifications for my understanding.

bundles/org.openhab.binding.tado/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.tado/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
...nding.tado/src/main/java/org/openhab/binding/tado/internal/handler/BaseHomeThingHandler.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.tado/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
andrewfg added 6 commits June 4, 2022 07:30
@andrewfg
[tado] reformat read me
3c3a85c 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[tado] increase maxReconnectAttempts
0e38709 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[tado] add i18n properties
fef2015 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[tado] bridge should ping the server every polling cycle
827f056 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[tado] maxReconnectAttempts, indefinitely = -1
2640f30 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
[tado] revert to attempt reconnection indefinitely
3546b68 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg requested a review from jlaur June 4, 2022 12:59
jlaur
jlaur approved these changes Jun 4, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur merged commit 3f4d1f0 into openhab:main Jun 4, 2022
@jlaur jlaur added this to the 3.3 milestone Jun 4, 2022
@Freeride79
Copy link

@andrewfg could you please provide me with a jar file that has the reconnection issue fixed? I see this issues irregularly

@andrewfg
Copy link
Contributor Author

andrewfg commented Jun 22, 2022 •
edited
Loading

@Freeride79 the PR has been merged so it is included in the OH official Milestone 7 release (and therefore the v3.3 final release next week).

CORRECTION: actually it was included in Milestone 6 already :)

@Freeride79
Copy link

@andrewfg Thank you very much, I'm looking forward for testing the new Milestone

@andrewfg andrewfg deleted the tado-#12704 branch September 26, 2022 16:36
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@andrewfg @leifbladt
[tado] Automatically reconnect offline Things if possible (openhab#12868
b258f41 
)

* [tado] reconnect offline things if possible & allowed
* [tado] bridge should ping the server every polling cycle

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@andrewfg @andan67
[tado] Automatically reconnect offline Things if possible (openhab#12868
3eb0546 
)

* [tado] reconnect offline things if possible & allowed
* [tado] bridge should ping the server every polling cycle

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@andrewfg @andrasU
[tado] Automatically reconnect offline Things if possible (openhab#12868
72ec3e4 
)

* [tado] reconnect offline things if possible & allowed
* [tado] bridge should ping the server every polling cycle

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@andrewfg @psmedley
[tado] Automatically reconnect offline Things if possible (openhab#12868
b790801 
)

* [tado] reconnect offline things if possible & allowed
* [tado] bridge should ping the server every polling cycle

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

[tado] Server timeouts and HTTP 409 errors
3 participants
@andrewfg @Freeride79 @jlaur