[neohub] Add support for WebSocket connection to hub #12915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
the
enhancement
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
requested changes
Jun 29, 2022
....openhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubHandler.java
Outdated
Show resolved
Hide resolved
....openhab.binding.neohub/src/test/java/org/openhab/binding/neohub/test/NeohubsocketTests.java
Outdated
Show resolved
Hide resolved
....openhab.binding.neohub/src/test/java/org/openhab/binding/neohub/test/NeohubsocketTests.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.neohub/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...penhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubWebSocket.java
Outdated
Show resolved
Hide resolved
...penhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubWebSocket.java
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
reviewed
Jul 31, 2022
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
reviewed
Jul 31, 2022
bundles/org.openhab.binding.neohub/src/main/resources/OH-INF/i18n/neohub.properties
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
reviewed
Jul 31, 2022
jlaur
reviewed
Jul 31, 2022
jlaur
reviewed
Jul 31, 2022
jlaur
reviewed
Jul 31, 2022
...penhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubWebSocket.java
Show resolved
Hide resolved
jlaur
reviewed
Jul 31, 2022
...penhab.binding.neohub/src/main/java/org/openhab/binding/neohub/internal/NeoHubWebSocket.java
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
jlaur
reviewed
Aug 1, 2022
...penhab.binding.neohub/src/test/java/org/openhab/binding/neohub/test/NeoHubProtocolTests.java
Outdated
Show resolved
Hide resolved
jlaur
reviewed
Aug 1, 2022
...penhab.binding.neohub/src/test/java/org/openhab/binding/neohub/test/NeoHubProtocolTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* [neohub] add support for secure web socket connection * [neohub] clean code * [neohub] synchronize api calls * [neohub] rename classes, fix compiler errors, remove SuppressWarnings Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [neohub] add support for secure web socket connection * [neohub] clean code * [neohub] synchronize api calls * [neohub] rename classes, fix compiler errors, remove SuppressWarnings Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [neohub] add support for secure web socket connection * [neohub] clean code * [neohub] synchronize api calls * [neohub] rename classes, fix compiler errors, remove SuppressWarnings Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [neohub] add support for secure web socket connection * [neohub] clean code * [neohub] synchronize api calls * [neohub] rename classes, fix compiler errors, remove SuppressWarnings Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* [neohub] add support for secure web socket connection * [neohub] clean code * [neohub] synchronize api calls * [neohub] rename classes, fix compiler errors, remove SuppressWarnings Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12909
Fixes #12899
As described in #12909 the manufacturer Heatmiser has implemented a new way of connecting to NeoHubs by means of a secure WSS web socket connection. This is in addition to the existing non-secure TCP socket connection.
This PR adds support for the OH binding to connect via such a web socket.
The web socket connection requires an additional configuration parameter
apiToken. Such tokens have to be created by the user for each hub on their Heatmiser mobile App. The read me explains how to do this.The support for the existing non-secure TCP socket connection is not removed. However if users want to continue using it, they now need to enable that via the Heatmiser mobile App. The read me already explains how to do this.
Note that #12909 also mentions that Heatmiser introduced a new way of discovering hubs on the LAN. However this has not been implemented, since the prior implemented method of discovery still works.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch