Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mynice] Binding for IT4Wifi module (Nice gate doors) #12940

Merged
merged 43 commits into from
Mar 10, 2023
Merged

[mynice] Binding for IT4Wifi module (Nice gate doors) #12940

merged 43 commits into from
Mar 10, 2023

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Jun 15, 2022 •
edited
Loading

This binding implements the support of the IT4Wifi module through the NHK protocol and enables management of Nice gates automatisms.

@clinique clinique requested a review from a team as a code owner June 15, 2022 12:34
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/nice-garage-door-binding-request/54593/30

@jlaur jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Jun 15, 2022
@clinique clinique self-assigned this Jun 16, 2022
@clinique clinique added the work in progress A PR that is not yet ready to be merged label Jul 15, 2022
@clinique clinique changed the title [mynice] New binding [mynice][wip] New binding Jul 15, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mynice-binding-beta/137570/1

@lolodomo
Copy link
Contributor

@clinique : is it finished and ready for a review?

@clinique
Copy link
Contributor Author

No. It is working but need to be cleaned and documented.

@clinique clinique changed the title [mynice][wip] New binding [mynice] Binding for IT4Wifi module (Nice gate doors) Jan 21, 2023
@clinique clinique removed the work in progress A PR that is not yet ready to be merged label Jan 21, 2023
@clinique clinique requested a review from wborn January 22, 2023 16:38
@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Feb 4, 2023
@lsiepel
Copy link
Contributor

lsiepel commented Feb 24, 2023

Can you fix the failed build? Not sure what is wrong, but i see this branch is 829 commits behing, so maybe you want to sync it again.

@clinique
Initiating new binding MyNice
675e975 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Saving work
7b7edf9 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Adding MDNS discovery participant to discover the IT4Wifi
c54d711 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Saving intermediate work
44590f5 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Save work
77ac72c 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Initial version
83ec6ab 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Preparing translation files
6c4fe26 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Changing username to mac address.
5996cbb 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Adding username to bridge configuration
52eb743 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Spotless apply
1c38a95 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Adding keep alive mechanism
e15bef9 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Reverting wrong modification
6648724 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Correction of SAT findings
f357790 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Correction of addon.xml
86dc6be 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Small modification
03d0ed6 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Pleasing Sat by updating headers
f75bf9c 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Fixing the mess
aa5e266 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Still some mixes with other bindings
1ff63fb 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Yet another left
1946cc5 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
The last leftover
22a4ea1 
Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique requested review from lsiepel and lolodomo February 24, 2023 13:44
lsiepel
lsiepel reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, do have some questions and minor suggestions.

bundles/org.openhab.binding.mynice/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mynice/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mynice/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mynice/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mynice/README.md Outdated Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Outdated Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Outdated Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Outdated Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Outdated Show resolved Hide resolved
@clinique
Code review corrections
d69a08a 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Some small corrections
1a97979 
Signed-off-by: clinique <gael@lhopital.org>
@lsiepel
Copy link
Contributor

lsiepel commented Feb 25, 2023

Thanks @clinique looks good to me. I'll leave the rest of the reviewing to a addons-maintainer.

jlaur
jlaur requested changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this new binding, looks good! Only a few comments from my side.

bundles/org.openhab.binding.mynice/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mynice/README.md Outdated Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Outdated Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Outdated Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Outdated Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Outdated Show resolved Hide resolved
...binding.mynice/src/main/java/org/openhab/binding/mynice/internal/handler/It4WifiHandler.java Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mynice/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.mynice/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
bundles/org.openhab.binding.mynice/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@clinique
Adressing code review comments from @jlaur
8e31211 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Clarification of obstruction.
cb12e2d 
Signed-off-by: clinique <gael@lhopital.org>
jlaur
jlaur approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clinique clinique requested a review from lsiepel March 10, 2023 09:28
@jlaur jlaur merged commit 3b5dfb1 into openhab:main Mar 10, 2023
@jlaur jlaur added this to the 4.0 milestone Mar 10, 2023
@jlaur
Copy link
Contributor

jlaur commented Mar 10, 2023

@clinique - now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

@clinique clinique deleted the mynice branch March 10, 2023 10:10
@clinique
Copy link
Contributor Author

clinique commented Mar 10, 2023 •
edited
Loading

@clinique - now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

Done

renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@clinique @renescherer
[mynice] Binding for IT4Wifi module (Nice gate doors) (openhab#12940)
8db5c48 
Signed-off-by: clinique <gael@lhopital.org>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@clinique @FordPrfkt
[mynice] Binding for IT4Wifi module (Nice gate doors) (openhab#12940)
f9d73b8 
Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@wborn wborn Awaiting requested review from wborn

@lolodomo lolodomo Awaiting requested review from lolodomo

@lsiepel lsiepel Awaiting requested review from lsiepel

Assignees

@clinique clinique

Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@clinique @openhab-bot @lolodomo @lsiepel @jlaur @wborn