[ipcamera] Fix multiple parts handling for Dahua events #12964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
ipcam-dahuaevents
branch
from
28034ce to
92c3e7a
Compare
jimtng
changed the title
jimtng
commented
Jun 19, 2022
...enhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/DahuaHandler.java
Show resolved
Hide resolved
|
To have this fix included in 3.3, we would need your feedback and review quickly, @Skinah Of course if this is possible. If not, this will be for 3.4. |
Skinah
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Yes the spelling error is in the firmware code and API documentation. I use copy paste heavily so it does not need to change.
Thanks for the suggested changes and I am a little hesitant rushing changes through for a stable build due to my lack of java experience. I can test the changes with multiple cameras tomorrow night, but after a quick look I think i am happy if the suggested change is accepted.
...enhab.binding.ipcamera/src/main/java/org/openhab/binding/ipcamera/internal/DahuaHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* [ipcamera] Fix multiple part handling for Dahua events * [ipcamera] Call processSettings only when data contains no boundary Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* [ipcamera] Fix multiple part handling for Dahua events * [ipcamera] Call processSettings only when data contains no boundary Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* [ipcamera] Fix multiple part handling for Dahua events * [ipcamera] Call processSettings only when data contains no boundary Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* [ipcamera] Fix multiple part handling for Dahua events * [ipcamera] Call processSettings only when data contains no boundary Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* [ipcamera] Fix multiple part handling for Dahua events * [ipcamera] Call processSettings only when data contains no boundary Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the data received by channelRead contains multiple parts. This PR splits them up and processes all the parts.
Resolve #11391 - this issue was mentioned in #11391 (comment)