[lcn] Add shutter positioning/angle, operating hours counters, tunable white, regulator mode, beeping #13056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e white, regulator mode, beeping Also, fix possible race condition during connecting, when the PC coupler is not connected to the LCN data wire. Replace discontinued LCN-PKE by LCN-VISU. Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
fwolter
added
the
enhancement
jlaur
requested changes
Jul 5, 2022
There was a problem hiding this comment.
Thanks for these improvements. It looks good, and I particularly like the ratio of test classes changed vs. total number of classes changed. :-) Only a small request to remove the updated German translation and instead provide the changes in Crowdin after having the PR merged. For reference: https://www.openhab.org/docs/developer/utils/i18n.html#managing-translations
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
|
Sure, fixed! |
|
Thanks! |
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…e white, regulator mode, beeping (openhab#13056) * [lcn] Add shutter positioning/angle, operating hours counters, tunable white, regulator mode, beeping Also, fix possible race condition during connecting, when the PC coupler is not connected to the LCN data wire. Replace discontinued LCN-PKE by LCN-VISU. Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…e white, regulator mode, beeping (openhab#13056) * [lcn] Add shutter positioning/angle, operating hours counters, tunable white, regulator mode, beeping Also, fix possible race condition during connecting, when the PC coupler is not connected to the LCN data wire. Replace discontinued LCN-PKE by LCN-VISU. Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…e white, regulator mode, beeping (openhab#13056) * [lcn] Add shutter positioning/angle, operating hours counters, tunable white, regulator mode, beeping Also, fix possible race condition during connecting, when the PC coupler is not connected to the LCN data wire. Replace discontinued LCN-PKE by LCN-VISU. Signed-off-by: Fabian Wolter <github@fabian-wolter.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…e white, regulator mode, beeping (openhab#13056) * [lcn] Add shutter positioning/angle, operating hours counters, tunable white, regulator mode, beeping Also, fix possible race condition during connecting, when the PC coupler is not connected to the LCN data wire. Replace discontinued LCN-PKE by LCN-VISU. Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…e white, regulator mode, beeping (openhab#13056) * [lcn] Add shutter positioning/angle, operating hours counters, tunable white, regulator mode, beeping Also, fix possible race condition during connecting, when the PC coupler is not connected to the LCN data wire. Replace discontinued LCN-PKE by LCN-VISU. Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix possible race condition during connecting, when the PC coupler is not connected to the LCN data wire.
Replace discontinued LCN-PKE by LCN-VISU.
Signed-off-by: Fabian Wolter github@fabian-wolter.de