[amazonechocontrol] Add channels to thermostatController #13067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
requested changes
Jul 20, 2022
...main/java/org/openhab/binding/amazonechocontrol/internal/handler/SmartHomeDeviceHandler.java
Outdated
Show resolved
Hide resolved
.../java/org/openhab/binding/amazonechocontrol/internal/smarthome/HandlerTemperatureSensor.java
Outdated
Show resolved
Hide resolved
...va/org/openhab/binding/amazonechocontrol/internal/smarthome/HandlerThermostatController.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.amazonechocontrol/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...hab.binding.amazonechocontrol/src/main/resources/OH-INF/i18n/amazonechocontrol_de.properties
Outdated
Show resolved
Hide resolved
jlaur
reviewed
Jul 20, 2022
...azonechocontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/Connection.java
Outdated
Show resolved
Hide resolved
jlaur
reviewed
Jul 25, 2022
...penhab.binding.amazonechocontrol/src/main/resources/OH-INF/i18n/amazonechocontrol.properties
Outdated
Show resolved
Hide resolved
|
@djcampbell - after fixing DCO and regenerating the i18n properties file, this PR can be merged. |
jlaur
reviewed
Jul 27, 2022
...penhab.binding.amazonechocontrol/src/main/resources/OH-INF/i18n/amazonechocontrol.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
djcampbell
force-pushed
the
amazonechocontrol-thermostat-add-channels
branch
from
edd9aca to
8469560
Compare
jlaur
reviewed
Jul 31, 2022
...penhab.binding.amazonechocontrol/src/main/resources/OH-INF/i18n/amazonechocontrol.properties
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
|
Thank you Jacob for all the time you spent reviewing this! I truly appreciate your patience! -Daniel |
Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* enhance: add thermostat channels to amazonechocontrol Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* enhance: add thermostat channels to amazonechocontrol Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* enhance: add thermostat channels to amazonechocontrol Signed-off-by: Daniel Campbell <djcampbell79@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* enhance: add thermostat channels to amazonechocontrol Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* enhance: add thermostat channels to amazonechocontrol Signed-off-by: Daniel Campbell <djcampbell79@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue described in #10260
Added 4 channels to amazonechocontrol:
Allows a user to change the operation mode of the Alexa Smart Thermostat
Allows a user to control upper and lower temperature thresholds when thermostat is in AUTO mode
Allows a user to view the current humidity reading from the thermostat
Full testing performed on local instance