Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[goecharger] Add transaction API key #13105

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

cribskip
Copy link
Contributor

This PR fixes #13104 and adds the transaction / trx api key to the binding.

@cribskip cribskip requested a review from SamuelBrucksch as a code owner July 10, 2022 09:02
@cribskip
Copy link
Contributor Author

As, crap, is there a way to fix the wrong sign-off-messages in the commits other than staring all over? Thanks :-)

@lolodomo
Copy link
Contributor

lolodomo commented Jul 17, 2022

Try squashing all your commits in one and then add the proper "Signed-off-by" entry to the tesulting commit.

@jlaur
Copy link
Contributor

jlaur commented Jul 22, 2022

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Aug 7, 2022
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>

Update goecharger.properties

Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>

Update GoEChargerBindingConstants.java

Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>

Update GoEStatusResponseV2DTO.java

Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>

Update GoEChargerV2Handler.java

Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>

Update README.md

Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>

Fix format and datatype issue

Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>

Fix format again

Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>

Fix type

Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>

Fix keyname

Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
@cribskip cribskip force-pushed the 13104-goe-add-transaction branch from 3592b46 to a739c78 Compare August 8, 2022 18:01
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

@jlaur : I let you merge when you like.

@jlaur jlaur merged commit 47b004f into openhab:main Aug 17, 2022
@jlaur jlaur added this to the 3.4 milestone Aug 17, 2022
@jlaur jlaur changed the title [goecharger] Add transaction api key [goecharger] Add transaction API key Aug 17, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[goecharger] Add transaction channel
3 participants