-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[goecharger] Add transaction API key #13105
Conversation
As, crap, is there a way to fix the wrong sign-off-messages in the commits other than staring all over? Thanks :-) |
Try squashing all your commits in one and then add the proper "Signed-off-by" entry to the tesulting commit. |
@cribskip - see third chapter here: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History |
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Update goecharger.properties Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Update GoEChargerBindingConstants.java Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Update GoEStatusResponseV2DTO.java Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Update GoEChargerV2Handler.java Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Update README.md Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Fix format and datatype issue Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Fix format again Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Fix type Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Fix keyname Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
3592b46
to
a739c78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jlaur : I let you merge when you like. |
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
Signed-off-by: Sascha Kloß <sascha.kloss@gmx.de>
This PR fixes #13104 and adds the transaction / trx api key to the binding.