Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mail] Fix sending HTML/Multipart mails #13108

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

hmerk
Copy link
Contributor

@hmerk hmerk commented Jul 10, 2022

Originally fixed in smarthomej/addons by @J-N-K
smarthomej/addons#378
The fix in smarthomej/addons#254 and #12568 was not sufficient for multipart messages as they contain a DataHandler for each body part. The command map was only set for the outer mime part, not for the body parts.

Signed-off-by: Hans-Jörg Merk github@hmerk.de
Also Signed-off-by: Jan N. Klug jan.n.klug@rub.de

Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
@hmerk hmerk requested a review from a team as a code owner July 10, 2022 12:00
@hmerk hmerk added the bug An unexpected problem or unintended behavior of an add-on label Jul 10, 2022
@kaikreuzer kaikreuzer added this to the 3.4 milestone Jul 10, 2022
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for porting this fix!

@kaikreuzer kaikreuzer merged commit e4ab458 into openhab:main Jul 10, 2022
@hmerk hmerk deleted the fix-sendhtmlmail branch July 10, 2022 13:52
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants