Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rotel] Fix request of play status and track number #13148

Merged
merged 1 commit into from
Jul 20, 2022
Merged

[rotel] Fix request of play status and track number #13148

merged 1 commit into from
Jul 20, 2022

Conversation

lolodomo
Copy link
Contributor

Impacted channels: track and playControl for models CD11, CD14 and RCD1572

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Jul 19, 2022
@lolodomo
[rotel] Fix syntax of few ASCII commands
a230217 
Impacted channels: track and playControl for models CD11, CD14 and RCD1572

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the rotel_fix_ascii_cmd_syntax branch from 14b1a1a to a230217 Compare July 19, 2022 23:33
@jlaur
Copy link
Contributor

jlaur commented Jul 20, 2022 •
edited
Loading

@lolodomo - can you describe the problem which is fixed? Code looks simple, but I have a hard time assessing it without any context. For the last two commands I can guess that question mark might be needed for querying values? For DSP_MODE I'm in doubt.

@lolodomo
Copy link
Contributor Author

lolodomo commented Jul 20, 2022 •
edited
Loading

As "?" was missing, the commands to retrieve the current playback status and current track number were certainly not working and corresponding channels were not set at Initialization.

Regarding the command to get the DSP mode, this is different. The 3 models use the ASCII V1 protocol and so the command get_dsp_mode. The command for ASCII V2 protocol is just not yet known.

@jlaur
Copy link
Contributor

jlaur commented Jul 20, 2022

Regarding the command to get the DSP mode, this is different. The 3 models use the ASCII V1 protocol and so the command get_dsp_mode. The command for ASCII V2 protocol is just not yet known.

Are some models still using the ASCII V1 protocol? Since that enum seems not model-specific, will DSP_MODE then stop working for any such models?

@jlaur
Copy link
Contributor

jlaur commented Jul 20, 2022

Regarding the command to get the DSP mode, this is different. The 3 models use the ASCII V1 protocol and so the command get_dsp_mode. The command for ASCII V2 protocol is just not yet known.

Are some models still using the ASCII V1 protocol? Since that enum seems not model-specific, will DSP_MODE then stop working for any such models?

Ah, sorry, now I get it. Last argument is for V2 protocol, and it's not known, so you removed it.

jlaur
jlaur approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you update the PR title to mention that requesting play status and track has been fixed, as this seems like a bugfix that could actually affect users?

@jlaur jlaur merged commit da3ec66 into openhab:main Jul 20, 2022
@jlaur jlaur added this to the 3.4 milestone Jul 20, 2022
@lolodomo lolodomo deleted the rotel_fix_ascii_cmd_syntax branch July 20, 2022 13:42
@lolodomo lolodomo changed the title [rotel] Fix syntax of few ASCII commands [rotel] Fix request of play status and track number Jul 21, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@lolodomo @leifbladt
[rotel] Fix syntax of few ASCII commands (openhab#13148)
181009d 
Impacted channels: track and playControl for models CD11, CD14 and RCD1572

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@lolodomo @andan67
[rotel] Fix syntax of few ASCII commands (openhab#13148)
89c771d 
Impacted channels: track and playControl for models CD11, CD14 and RCD1572

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@lolodomo @andrasU
[rotel] Fix syntax of few ASCII commands (openhab#13148)
0fb3fa7 
Impacted channels: track and playControl for models CD11, CD14 and RCD1572

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@lolodomo @psmedley
[rotel] Fix syntax of few ASCII commands (openhab#13148)
6ee36d6 
Impacted channels: track and playControl for models CD11, CD14 and RCD1572

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@lolodomo @nemerdaud
[rotel] Fix syntax of few ASCII commands (openhab#13148)
ce1a9bf 
Impacted channels: track and playControl for models CD11, CD14 and RCD1572

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@lolodomo @jlaur