[jrubyscripting] Check if gems are installed before installing them #13151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jimtng |
|
hmm, @jimtng brings up a good point that this would defeat auto-update on restart. will have to think on it... |
ccutrer
force-pushed
the
jruby_avoid_duplicate_gem_installs
branch
from
21bb0a9 to
ce25f52
Compare
|
@jimtng : okay, updated now with support for auto-update, and a config option for if you even want auto-update behavior. I am using bundler/inline now (the only way I could figure out how to get it to check-before-installing). I had to pass an explicit |
jimtng
requested changes
Jul 26, 2022
...main/java/org/openhab/automation/jrubyscripting/internal/JRubyScriptEngineConfiguration.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.automation.jrubyscripting/src/main/resources/OH-INF/config/config.xml
Show resolved
Hide resolved
ccutrer
force-pushed
the
jruby_avoid_duplicate_gem_installs
branch
from
ce25f52 to
13546ac
Compare
jimtng
approved these changes
Jul 27, 2022
jimtng
requested changes
Jul 27, 2022
jimtng
reviewed
Jul 27, 2022
bundles/org.openhab.automation.jrubyscripting/src/main/resources/OH-INF/config/config.xml
Outdated
Show resolved
Hide resolved
this avoids unecessary downloads and overwrites, or even more importantly errors if the GEM_HOME is not writable by the openhab user. this also adds a configuration option for if you want to check for updates every time configuration is applied (or openhab restarts). this is useful if your OpenHAB system can't access the internet regularly. Signed-off-by: Cody Cutrer <cody@cutrer.us>
ccutrer
force-pushed
the
jruby_avoid_duplicate_gem_installs
branch
from
13546ac to
2d5771d
Compare
|
README updated |
jlaur
requested changes
Jul 31, 2022
|
@boc-tothefuture - do you also want to have a look? |
jimtng
reviewed
Aug 1, 2022
Co-authored-by: jimtng <2554958+jimtng@users.noreply.github.com>
jlaur
changed the title
|
@kaikreuzer this didn't get mentioned in the 3.4 M1 announcement https://github.com/openhab/openhab-distro/releases/tag/3.4.0.M1 |
This is because it lacks a bug or enhancement label, which I didn't notice previously. I guess it should be enhancement due to the "org.openhab.automation.jrubyscripting:check_update" addition? I'm adding that, so it will be included in the final 3.4 release notes. Feel free to change it. |
ccutrer
added a commit
to ccutrer/openhab-addons
that referenced
this pull request
Aug 27, 2022
fixes boc-tothefuture/openhab-jruby#634; regression from openhab#13151 Signed-Off-By: Cody Cutrer <cody@cutrer.us>
jlaur
pushed a commit
that referenced
this pull request
Aug 28, 2022
#13328) fixes boc-tothefuture/openhab-jruby#634; regression from #13151 Signed-Off-By: Cody Cutrer <cody@cutrer.us>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…penhab#13151) * [jrubyscripting] check if gems are installed before installing them this avoids unecessary downloads and overwrites, or even more importantly errors if the GEM_HOME is not writable by the openhab user. this also adds a configuration option for if you want to check for updates every time configuration is applied (or openhab restarts). this is useful if your OpenHAB system can't access the internet regularly. Signed-off-by: Cody Cutrer <cody@cutrer.us>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
openhab#13328) fixes boc-tothefuture/openhab-jruby#634; regression from openhab#13151 Signed-Off-By: Cody Cutrer <cody@cutrer.us>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…penhab#13151) * [jrubyscripting] check if gems are installed before installing them this avoids unecessary downloads and overwrites, or even more importantly errors if the GEM_HOME is not writable by the openhab user. this also adds a configuration option for if you want to check for updates every time configuration is applied (or openhab restarts). this is useful if your OpenHAB system can't access the internet regularly. Signed-off-by: Cody Cutrer <cody@cutrer.us>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
openhab#13328) fixes boc-tothefuture/openhab-jruby#634; regression from openhab#13151 Signed-Off-By: Cody Cutrer <cody@cutrer.us>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…penhab#13151) * [jrubyscripting] check if gems are installed before installing them this avoids unecessary downloads and overwrites, or even more importantly errors if the GEM_HOME is not writable by the openhab user. this also adds a configuration option for if you want to check for updates every time configuration is applied (or openhab restarts). this is useful if your OpenHAB system can't access the internet regularly. Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
openhab#13328) fixes boc-tothefuture/openhab-jruby#634; regression from openhab#13151 Signed-Off-By: Cody Cutrer <cody@cutrer.us> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Nov 14, 2022
openhab#13328) fixes boc-tothefuture/openhab-jruby#634; regression from openhab#13151 Signed-Off-By: Cody Cutrer <cody@cutrer.us>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…penhab#13151) * [jrubyscripting] check if gems are installed before installing them this avoids unecessary downloads and overwrites, or even more importantly errors if the GEM_HOME is not writable by the openhab user. this also adds a configuration option for if you want to check for updates every time configuration is applied (or openhab restarts). this is useful if your OpenHAB system can't access the internet regularly. Signed-off-by: Cody Cutrer <cody@cutrer.us>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
openhab#13328) fixes boc-tothefuture/openhab-jruby#634; regression from openhab#13151 Signed-Off-By: Cody Cutrer <cody@cutrer.us>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…penhab#13151) * [jrubyscripting] check if gems are installed before installing them this avoids unecessary downloads and overwrites, or even more importantly errors if the GEM_HOME is not writable by the openhab user. this also adds a configuration option for if you want to check for updates every time configuration is applied (or openhab restarts). this is useful if your OpenHAB system can't access the internet regularly. Signed-off-by: Cody Cutrer <cody@cutrer.us>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
openhab#13328) fixes boc-tothefuture/openhab-jruby#634; regression from openhab#13151 Signed-Off-By: Cody Cutrer <cody@cutrer.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this avoids unecessary downloads and overwrites, or even more importantly
errors if the GEM_HOME is not writable by the openhab user.