-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rotel] New channel for other commands provided by the API #13183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Jul 28, 2022
lolodomo
force-pushed
the
rotel_other_cmds
branch
5 times, most recently
from
July 30, 2022 17:15
cde9265
to
3d5b9f6
Compare
Models covered by this PR: A11, A12, A14, CD11, CD12, RA11, RA12, RA1570, RA1572, RC1570, RC1572, RCD1572, P5, X3, X5, RSP-1066, RSP-1068, RSP-1069, RSP-1098, RSP-1570, RSP-1572, RSX-1055, RSX-1056, RSX-1057, RSX-1058, RSX-1065, RSX-1067, RSX-1550, RSX-1560, RSX-1562 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
rotel_other_cmds
branch
from
July 30, 2022 17:32
3d5b9f6
to
a81c287
Compare
jlaur
approved these changes
Jul 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! One minor suggestion to consider.
...nding.rotel/src/main/java/org/openhab/binding/rotel/internal/communication/RotelCommand.java
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Thank you. |
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…3183) * [rotel] New channel for other commands provided by the API Models covered by this PR: A11, A12, A14, CD11, CD12, RA11, RA12, RA1570, RA1572, RC1570, RC1572, RCD1572, P5, X3, X5, RSP-1066, RSP-1068, RSP-1069, RSP-1098, RSP-1570, RSP-1572, RSX-1055, RSX-1056, RSX-1057, RSX-1058, RSX-1065, RSX-1067, RSX-1550, RSX-1560, RSX-1562 * Review comment: toString on RotelCommand Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…3183) * [rotel] New channel for other commands provided by the API Models covered by this PR: A11, A12, A14, CD11, CD12, RA11, RA12, RA1570, RA1572, RC1570, RC1572, RCD1572, P5, X3, X5, RSP-1066, RSP-1068, RSP-1069, RSP-1098, RSP-1570, RSP-1572, RSX-1055, RSX-1056, RSX-1057, RSX-1058, RSX-1065, RSX-1067, RSX-1550, RSX-1560, RSX-1562 * Review comment: toString on RotelCommand Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…3183) * [rotel] New channel for other commands provided by the API Models covered by this PR: A11, A12, A14, CD11, CD12, RA11, RA12, RA1570, RA1572, RC1570, RC1572, RCD1572, P5, X3, X5, RSP-1066, RSP-1068, RSP-1069, RSP-1098, RSP-1570, RSP-1572, RSX-1055, RSX-1056, RSX-1057, RSX-1058, RSX-1065, RSX-1067, RSX-1550, RSX-1560, RSX-1562 * Review comment: toString on RotelCommand Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…3183) * [rotel] New channel for other commands provided by the API Models covered by this PR: A11, A12, A14, CD11, CD12, RA11, RA12, RA1570, RA1572, RC1570, RC1572, RCD1572, P5, X3, X5, RSP-1066, RSP-1068, RSP-1069, RSP-1098, RSP-1570, RSP-1572, RSX-1055, RSX-1056, RSX-1057, RSX-1058, RSX-1065, RSX-1067, RSX-1550, RSX-1560, RSX-1562 * Review comment: toString on RotelCommand Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…3183) * [rotel] New channel for other commands provided by the API Models covered by this PR: A11, A12, A14, CD11, CD12, RA11, RA12, RA1570, RA1572, RC1570, RC1572, RCD1572, P5, X3, X5, RSP-1066, RSP-1068, RSP-1069, RSP-1098, RSP-1570, RSP-1572, RSX-1055, RSX-1056, RSX-1057, RSX-1058, RSX-1065, RSX-1067, RSX-1550, RSX-1560, RSX-1562 * Review comment: toString on RotelCommand Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Models covered by this PR:
A11, A12, A14, CD11, CD12, RA11, RA12, RA1570, RA1572, RC1570, RC1572, RCD1572, P5, X3, X5,
RSP-1066, RSP-1068, RSP-1069, RSP-1098, RSP-1570, RSP-1572,
RSX-1055, RSX-1056, RSX-1057, RSX-1058, RSX-1065, RSX-1067, RSX-1550, RSX-1560, RSX-1562
Signed-off-by: Laurent Garnier lg.hc@free.fr