Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] fix rollershutter return as position always undef #13191

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

vich-667
Copy link
Contributor

@vich-667 vich-667 commented Jul 29, 2022

Fix ISSUE 11686 . It worked to me on my local tryout.

@vich-667 vich-667 closed this Jul 29, 2022
@vich-667 vich-667 reopened this Aug 2, 2022
@vich-667 vich-667 changed the title return rollershutter pos [http] rollershutter return as position always undef Aug 2, 2022
Signed-off-by: Tobias Lange <vich-667@gmx.de>
@vich-667 vich-667 force-pushed the task/rollshutter-get-pos branch from ac41a51 to f010115 Compare August 2, 2022 19:39
@vich-667 vich-667 marked this pull request as ready for review August 15, 2022 23:59
@vich-667 vich-667 requested a review from a team as a code owner August 15, 2022 23:59
@vich-667 vich-667 changed the title [http] rollershutter return as position always undef [http] fix rollershutter return as position always undef Aug 16, 2022
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Aug 17, 2022
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 7e9e0db into openhab:main Aug 17, 2022
@lolodomo lolodomo added this to the 3.4 milestone Aug 17, 2022
marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Aug 18, 2022
Signed-off-by: Tobias Lange <vich-667@gmx.de>
Signed-off-by: Marcel Goerentz <m.goerentz@t-online.de>
@vich-667 vich-667 deleted the task/rollshutter-get-pos branch August 23, 2022 14:18
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
Signed-off-by: Tobias Lange <vich-667@gmx.de>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Tobias Lange <vich-667@gmx.de>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Tobias Lange <vich-667@gmx.de>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Tobias Lange <vich-667@gmx.de>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Tobias Lange <vich-667@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[http-binding]: Inbound state is not fully implemented on the rollershutter channel type
2 participants