[velux] Add an action to simultaneously set main and vane positions #13199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
enhancement
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
…hab-addons into 13049-velux-action
andrewfg
removed
the
additional testing preferred
|
User has confirmed functionality. => Converting from draft to active PR. |
lolodomo
requested changes
Aug 14, 2022
...nhab.binding.velux/src/main/java/org/openhab/binding/velux/internal/action/VeluxActions.java
Outdated
Show resolved
Hide resolved
...nhab.binding.velux/src/main/java/org/openhab/binding/velux/internal/action/VeluxActions.java
Show resolved
Hide resolved
...nhab.binding.velux/src/main/java/org/openhab/binding/velux/internal/action/VeluxActions.java
Show resolved
Hide resolved
...nding.velux/src/main/java/org/openhab/binding/velux/internal/handler/VeluxBridgeHandler.java
Outdated
Show resolved
Hide resolved
...nding.velux/src/main/java/org/openhab/binding/velux/internal/handler/VeluxBridgeHandler.java
Outdated
Show resolved
Hide resolved
...nding.velux/src/main/java/org/openhab/binding/velux/internal/handler/VeluxBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
lolodomo
requested changes
Aug 14, 2022
...nhab.binding.velux/src/main/java/org/openhab/binding/velux/internal/action/VeluxActions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
added
rebuild
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Aug 18, 2022
…penhab#13199) * [velux] add moveMainAndVane action * [velux] add claridications to read me * [velux] refactor actions and translate * [velux] fix thing lookup Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Marcel Goerentz <m.goerentz@t-online.de>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…penhab#13199) * [velux] add moveMainAndVane action * [velux] add claridications to read me * [velux] refactor actions and translate * [velux] fix thing lookup Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…penhab#13199) * [velux] add moveMainAndVane action * [velux] add claridications to read me * [velux] refactor actions and translate * [velux] fix thing lookup Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…penhab#13199) * [velux] add moveMainAndVane action * [velux] add claridications to read me * [velux] refactor actions and translate * [velux] fix thing lookup Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…penhab#13199) * [velux] add moveMainAndVane action * [velux] add claridications to read me * [velux] refactor actions and translate * [velux] fix thing lookup Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…penhab#13199) * [velux] add moveMainAndVane action * [velux] add claridications to read me * [velux] refactor actions and translate * [velux] fix thing lookup Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In PR #12618 we added support for vane/slat position on shutters that have vanes.
On such shutters, if one sends a main position command followed quickly by a vane position command (or vice-versa) while the shutter is still moving to the position given in the first command, then the second command causes the movement of the first command to stop, and starts the movement of the second command.
Requirement
As described in #13049 there is a need to issue simultaneous main and vane position commands from within a rule, so that both positions will be set without the one cancelling the other.
Solution
This PR adds a
moveMainAndVane()action that can be triggered by a rule to simultaneously set both main position and vane position.Fixes #13049
Note: this PR also includes some extra clarifications in the ReadMe about initial configuration of devices in the KLF200 hub. And concerning the hub's temporary Wi-Fi access point.
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch