Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonos] Ignore TRANSITIONING device state when updating channels #13241

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier lg.hc@free.fr

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Aug 10, 2022
@lolodomo lolodomo requested a review from kgoderis as a code owner August 10, 2022 18:00
@lolodomo
Copy link
Contributor Author

Here is a jar for testing (renamed the file with extension jar first):
org.openhab.binding.sonos-3.4.0-SNAPSHOT.zip

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/inconsistent-state-reported-by-sonos-state-channels/137983/14

@lolodomo lolodomo added community approved and removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Aug 10, 2022
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@jlaur jlaur merged commit 4eb74c4 into openhab:main Aug 11, 2022
@jlaur jlaur added this to the 3.4 milestone Aug 11, 2022
@lolodomo lolodomo deleted the sonos_state_transitioning branch August 11, 2022 06:36
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
…nhab#13241)

* [sonos] Ignore TRANSITIONING device state when updating channels
* Remove TRANSITIONING state option

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…nhab#13241)

* [sonos] Ignore TRANSITIONING device state when updating channels
* Remove TRANSITIONING state option

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…nhab#13241)

* [sonos] Ignore TRANSITIONING device state when updating channels
* Remove TRANSITIONING state option

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
…nhab#13241)

* [sonos] Ignore TRANSITIONING device state when updating channels
* Remove TRANSITIONING state option

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…nhab#13241)

* [sonos] Ignore TRANSITIONING device state when updating channels
* Remove TRANSITIONING state option

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on community approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants