Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Support one decimal for pressure values #13257

Merged
merged 1 commit into from
Aug 14, 2022
Merged

[netatmo] Support one decimal for pressure values #13257

merged 1 commit into from
Aug 14, 2022

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Aug 13, 2022

Fixes #13243

@jlaur
Support one decimal for pressure value
fde08c9 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Aug 13, 2022
@lolodomo
Copy link
Contributor

@jlaur : did you test? @Yogi4301 is telling that changing the pattern is not sufficient.

@jlaur
Copy link
Contributor Author

jlaur commented Aug 14, 2022

@jlaur : did you test? @Yogi4301 is telling that changing the pattern is not sufficient.

Yes, of course. :) Changing pattern didn't help because the binding was rounding to nearest integer, although one decimal is actually available. This fixes that.

@lolodomo
Copy link
Contributor

Changing pattern didn't help because the binding was rounding to nearest integer, although one decimal is actually available. This fixes that.

Did not see that in the code.
Ok, fine.

@lolodomo lolodomo merged commit 6853fe8 into openhab:main Aug 14, 2022
@lolodomo lolodomo added this to the 3.4 milestone Aug 14, 2022
@jlaur jlaur deleted the 13243-netatmo-pressure-precision branch August 15, 2022 21:05
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@jlaur @leifbladt
Support one decimal for pressure value (openhab#13257)
99f1c22 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@jlaur @andan67
Support one decimal for pressure value (openhab#13257)
c139301 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@jlaur @andrasU
Support one decimal for pressure value (openhab#13257)
2b3d479 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@jlaur @psmedley
Support one decimal for pressure value (openhab#13257)
be306c9 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@jlaur @nemerdaud
Support one decimal for pressure value (openhab#13257)
38f83b3 
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@clinique clinique Awaiting requested review from clinique clinique is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

[Netatmo] Reenabling one decimal digit for pressure values
2 participants
@jlaur @lolodomo