[Hydrawise] concurrent error #13268
Merged
[Hydrawise] concurrent error #13268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
…se, fixes totally broken last contact channel Fixes openhab#13094 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Do you really want to rename channel and channel type? This would be a breaking change. |
This channel has never worked since the binding was rewritten, and i only found out it was broken from an off hand comment on an unrelated bug, so i think the right thing todo is to change this to be the correct channel name across the board. Since it's never worked, and only one person has mentioned it, i would not consider it a breaking change (or i would have just stuck with what was there). |
|
As users will have to recreate their things, I think this has to be tagged as a breaking change, even if only few users installed this binding. |
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Aug 18, 2022
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel Fixes openhab#13094 Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Marcel Goerentz <m.goerentz@t-online.de>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel Fixes openhab#13094 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
@digitaldan : maybe you could add a compatibility note for upgrade to 3.4 ? |
|
Yes |
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel Fixes openhab#13094 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel Fixes openhab#13094 Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel Fixes openhab#13094 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel Fixes openhab#13094 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel
Fixes #13094