-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[velux] Vane position channel is visible when required #13271
Conversation
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/dynamically-created-channel-not-showing-up-in-main-ui/138150/21 |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
bundles/org.openhab.binding.velux/src/main/resources/OH-INF/thing/rollershutter.xml
Outdated
Show resolved
Hide resolved
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/dynamically-created-channel-not-showing-up-in-main-ui/138150/24 |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
...nding.velux/src/main/java/org/openhab/binding/velux/internal/handler/VeluxBridgeHandler.java
Outdated
Show resolved
Hide resolved
...nding.velux/src/main/java/org/openhab/binding/velux/internal/handler/VeluxBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@lolodomo please hold; in the handler calling EDIT: ok I checked again. It is all good :) |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Converted this to draft until the way forward for other similar PRs has been resolved. |
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@lolodomo just an update to avoid any (further) confusion..
=> So we are ready to go on this one again! :) |
...hab.binding.velux/src/main/java/org/openhab/binding/velux/internal/handler/VeluxHandler.java
Outdated
Show resolved
Hide resolved
...hab.binding.velux/src/main/java/org/openhab/binding/velux/internal/handler/VeluxHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.velux/src/main/resources/OH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.velux/src/main/resources/OH-INF/thing/window.xml
Show resolved
Hide resolved
...hab.binding.velux/src/main/java/org/openhab/binding/velux/internal/handler/VeluxHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
bundles/org.openhab.binding.velux/src/main/resources/OH-INF/i18n/velux.properties
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [velux] make vanePosition channel dynamic * [velux] change category of window position from 'blinds' to 'window' Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] make vanePosition channel dynamic * [velux] change category of window position from 'blinds' to 'window' Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] make vanePosition channel dynamic * [velux] change category of window position from 'blinds' to 'window' Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
* [velux] make vanePosition channel dynamic * [velux] change category of window position from 'blinds' to 'window' Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] make vanePosition channel dynamic * [velux] change category of window position from 'blinds' to 'window' Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* [velux] make vanePosition channel dynamic * [velux] change category of window position from 'blinds' to 'window' Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Background
In #12618 we added support for a vane position channel on venetian style blinds. And in that PR the respective
vanePosition
channel was created statically for ALL types of shutters and blinds regardless of whether the actual shutter/blind does physically support vanes. This could be confusing for users who have shutters / blinds that do not support vanes.Solution
In this PR the binding queries each shutter/blind in the hub, and if that device actually supports vanes, then the binding will create a
vanePosition
channel dynamically.Resolves #13260
Acknowledgments
PS many thanks to @pacive, @splatch, @lolodomo and @jlaur for support via the community forum..
https://community.openhab.org/t/dynamically-created-channel-not-showing-up-in-main-ui/138150
Signed-off-by: Andrew Fiddian-Green software@whitebear.ch