Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fineoffsetweatherstation] Add channel for the sensors battery voltage #13284

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

Andy2003
Copy link
Contributor

Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
@Andy2003 Andy2003 added the enhancement An enhancement or new feature for an existing add-on label Aug 17, 2022
@Andy2003 Andy2003 requested a review from jlaur August 17, 2022 16:55
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/fine-offset-weather-station-binding-beta-and-discussion/134167/86

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Two minor things to consider.

…ition

Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
@Andy2003 Andy2003 requested a review from jlaur August 18, 2022 06:58
@jlaur jlaur changed the title [fineoffsetweatherstation] add channel for the sensors battery voltage [fineoffsetweatherstation] Add channel for the sensors battery voltage Aug 18, 2022
Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
@Andy2003 Andy2003 requested a review from jlaur August 18, 2022 07:39
@Hilbrand
Copy link
Member

It is not allowed to create branches on the openHAB repo itself!

@Andy2003
Copy link
Contributor Author

It is not allowed to create branches on the openHAB repo itself!

Sorry, this was an oversight. should I delete the branch and create a new PR, or can we continue here?

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit e49cde0 into main Aug 18, 2022
@jlaur jlaur added this to the 3.4 milestone Aug 18, 2022
@jlaur jlaur deleted the feature/add-battery-voltage-channel branch August 18, 2022 10:14
@jlaur
Copy link
Contributor

jlaur commented Aug 18, 2022

@Andy2003 - I have merged now and deleted the branch.

leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
openhab#13284)

* [fineoffsetweatherstation] add channel for the sensors battery voltage

Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
openhab#13284)

* [fineoffsetweatherstation] add channel for the sensors battery voltage

Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
openhab#13284)

* [fineoffsetweatherstation] add channel for the sensors battery voltage

Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
openhab#13284)

* [fineoffsetweatherstation] add channel for the sensors battery voltage

Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
openhab#13284)

* [fineoffsetweatherstation] add channel for the sensors battery voltage

Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants