-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fineoffsetweatherstation] Add channel for the sensors battery voltage #13284
Conversation
Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/fine-offset-weather-station-binding-beta-and-discussion/134167/86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Two minor things to consider.
bundles/org.openhab.binding.fineoffsetweatherstation/src/main/resources/OH-INF/thing/sensor.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.fineoffsetweatherstation/src/main/resources/OH-INF/thing/sensor.xml
Show resolved
Hide resolved
…ition Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
bundles/org.openhab.binding.fineoffsetweatherstation/src/main/resources/OH-INF/thing/sensor.xml
Show resolved
Hide resolved
Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
It is not allowed to create branches on the openHAB repo itself! |
Sorry, this was an oversight. should I delete the branch and create a new PR, or can we continue here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Andy2003 - I have merged now and deleted the branch. |
openhab#13284) * [fineoffsetweatherstation] add channel for the sensors battery voltage Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
openhab#13284) * [fineoffsetweatherstation] add channel for the sensors battery voltage Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
openhab#13284) * [fineoffsetweatherstation] add channel for the sensors battery voltage Signed-off-by: Andreas Berger <andreas@berger-freelancer.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
openhab#13284) * [fineoffsetweatherstation] add channel for the sensors battery voltage Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
openhab#13284) * [fineoffsetweatherstation] add channel for the sensors battery voltage Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
for discussion see here: https://community.openhab.org/t/fine-offset-weather-station-binding-beta-and-discussion/134167/80