-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Konnected] Fixed null pointer exception on state update with missing state #13329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haavar Valeur <haavar@haavar.com>
jlaur
requested changes
Aug 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One minor comment to consider.
...konnected/src/main/java/org/openhab/binding/konnected/internal/handler/KonnectedHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Haavar Valeur <haavar@haavar.com>
jlaur
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
… state (openhab#13329) * Fixed null pointer exception on state update with missing state * Added variable for state. Changed onvalue configuration type to integer. Signed-off-by: Haavar Valeur <haavar@haavar.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
… state (openhab#13329) * Fixed null pointer exception on state update with missing state * Added variable for state. Changed onvalue configuration type to integer. Signed-off-by: Haavar Valeur <haavar@haavar.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
… state (openhab#13329) * Fixed null pointer exception on state update with missing state * Added variable for state. Changed onvalue configuration type to integer. Signed-off-by: Haavar Valeur <haavar@haavar.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Nov 14, 2022
… state (openhab#13329) * Fixed null pointer exception on state update with missing state * Added variable for state. Changed onvalue configuration type to integer. Signed-off-by: Haavar Valeur <haavar@haavar.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
… state (openhab#13329) * Fixed null pointer exception on state update with missing state * Added variable for state. Changed onvalue configuration type to integer. Signed-off-by: Haavar Valeur <haavar@haavar.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
… state (openhab#13329) * Fixed null pointer exception on state update with missing state * Added variable for state. Changed onvalue configuration type to integer. Signed-off-by: Haavar Valeur <haavar@haavar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hitting a race condition when adding zones. The status seems to be missing from the panel's json response right after new configuration is pushed to the panel and the panel restarts. The was causing a NullPointerException.