Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Konnected] Fixed null pointer exception on state update with missing state #13329

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

haavar
Copy link
Contributor

@haavar haavar commented Aug 28, 2022

I was hitting a race condition when adding zones. The status seems to be missing from the panel's json response right after new configuration is pushed to the panel and the panel restarts. The was causing a NullPointerException.

Signed-off-by: Haavar Valeur <haavar@haavar.com>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Aug 28, 2022
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor comment to consider.

Signed-off-by: Haavar Valeur <haavar@haavar.com>
@haavar haavar requested a review from jlaur August 29, 2022 03:49
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 07e2b69 into openhab:main Aug 29, 2022
@jlaur jlaur added this to the 3.4 milestone Aug 29, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
… state (openhab#13329)

* Fixed null pointer exception on state update with missing state
* Added variable for state. Changed onvalue configuration type to integer.

Signed-off-by: Haavar Valeur <haavar@haavar.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
… state (openhab#13329)

* Fixed null pointer exception on state update with missing state
* Added variable for state. Changed onvalue configuration type to integer.

Signed-off-by: Haavar Valeur <haavar@haavar.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
… state (openhab#13329)

* Fixed null pointer exception on state update with missing state
* Added variable for state. Changed onvalue configuration type to integer.

Signed-off-by: Haavar Valeur <haavar@haavar.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Nov 14, 2022
… state (openhab#13329)

* Fixed null pointer exception on state update with missing state
* Added variable for state. Changed onvalue configuration type to integer.

Signed-off-by: Haavar Valeur <haavar@haavar.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
… state (openhab#13329)

* Fixed null pointer exception on state update with missing state
* Added variable for state. Changed onvalue configuration type to integer.

Signed-off-by: Haavar Valeur <haavar@haavar.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
… state (openhab#13329)

* Fixed null pointer exception on state update with missing state
* Added variable for state. Changed onvalue configuration type to integer.

Signed-off-by: Haavar Valeur <haavar@haavar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants