Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remoteopenhab] Fix the pattern to parse DateTime #13349

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Sep 3, 2022

Re-use the same pattern as defined in class DateTimeTyoe.

Allows the support of 0 to 9 digits after the seconds.

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Sep 3, 2022
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/time-reading-from-remote-oh-instance-not-accepted-via-remote-openhab-binding/138214/11

Re-use the same pattern as defined in class DateTimeTyoe.

Allows the support of 0 to 9 digits after the seconds.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the remoteoh_datetime_format branch from fe2d629 to c5a711e Compare September 3, 2022 09:34
@lolodomo
Copy link
Contributor Author

lolodomo commented Sep 3, 2022

Here is a jar for testing:
org.openhab.binding.remoteopenhab-3.4.0-SNAPSHOT.zip

@lolodomo lolodomo removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Sep 3, 2022
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@jlaur jlaur merged commit c462599 into openhab:main Sep 6, 2022
@jlaur jlaur added this to the 3.4 milestone Sep 6, 2022
@lolodomo lolodomo deleted the remoteoh_datetime_format branch September 6, 2022 19:33
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
Re-use the same pattern as defined in class DateTimeTyoe.

Allows the support of 0 to 9 digits after the seconds.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@openhab-bot
Copy link
Collaborator

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Re-use the same pattern as defined in class DateTimeTyoe.

Allows the support of 0 to 9 digits after the seconds.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Re-use the same pattern as defined in class DateTimeTyoe.

Allows the support of 0 to 9 digits after the seconds.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Nov 14, 2022
Re-use the same pattern as defined in class DateTimeTyoe.

Allows the support of 0 to 9 digits after the seconds.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Re-use the same pattern as defined in class DateTimeTyoe.

Allows the support of 0 to 9 digits after the seconds.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Re-use the same pattern as defined in class DateTimeTyoe.

Allows the support of 0 to 9 digits after the seconds.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants