Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radiothermostat] Ignore updates if thermostat data is invalid #13394

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

mlobstein
Copy link
Contributor

@mlobstein mlobstein commented Sep 16, 2022

It could be that my thermostat is beginning to fail since it has started randomly returning -1 instead of the actual temperature. This change will cause a polling update with invalid data to be ignored so it will not update the channels. As a result, the temperature graphs will no longer look like this:

temp dropout

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein added bug An unexpected problem or unintended behavior of an add-on rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 16, 2022
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein requested a review from lolodomo September 17, 2022 15:10
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 8a9c66a into openhab:main Sep 17, 2022
@lolodomo lolodomo added this to the 3.4 milestone Sep 17, 2022
@mlobstein mlobstein deleted the radiothermostat_invalidData branch September 17, 2022 17:26
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
…ab#13394)

* Ignore updates if data is invalid

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…ab#13394)

* Ignore updates if data is invalid

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
…ab#13394)

* Ignore updates if data is invalid

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
…ab#13394)

* Ignore updates if data is invalid

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
…ab#13394)

* Ignore updates if data is invalid

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants